Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extensions deduplication #54

Merged
merged 9 commits into from
Dec 10, 2015
Merged

Extensions deduplication #54

merged 9 commits into from
Dec 10, 2015

Conversation

tomato42
Copy link
Member

since the on-the-wire encoding of those extensions is (almost)
identical, we can create an "abstract" extension that implements them
all and just depends on specific initialization

@landscape-bot
Copy link

Code Health
Repository health increased by 0.19% when pulling 527ee15 on extensions-deduplication into 07358fc on master.

@tomato42
use parser functions in extensions
26d664b
@tomato42
deduplicate code in extensions writers
f730d7b
@tomato42
deduplicate extensions using just a list of values
5f47c26 
since the on-the-wire encoding of those extensions is (almost)
identical, we can create an "abstract" extension that implements them
all and just depends on specific initialization
@tomato42
deduplicate TLSExtension parser
d5efeb6
@tomato42
allow for magic methods
3c31734 
methods like __getattr__ are necessary for python to work
properly so allow them
@tomato42
use project-standard variable names
38d49d5
@tomato42
make possible for child classes to call super init
703f3a5 
make sure that calling super().__init__ won't blow up in other
Extension classes and that the ext type is defined in the
topmost class
@tomato42
move extType out of rest of Extension classes
ba2957b
@tomato42 tomato42 added the review request PR finished, ready for review label Dec 1, 2015
@tomato42
document how to create TLSExtension child classes
e64f788 
since creating new extensions is not entirely straight-forward,
describe which methods and properties must be overriden by subclasses
to add implementation of a new extension
@The-Mule
Copy link
Collaborator

It's all good - r+.

@tomato42 tomato42 merged commit e64f788 into master Dec 10, 2015
@tomato42
Copy link
Member Author

Thanks for the review!

@tomato42 tomato42 deleted the extensions-deduplication branch December 10, 2015 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review request PR finished, ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomato42 @landscape-bot @The-Mule