DOMAINNAME can fail to be set in postsrsd-wrapper.sh #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the container doesn’t have a proper hostname, postsrsd will fail to start because SRS_DOMAIN is empty. Make a best effort to figure out the domain name and provide a way to set one if needed.
|
Could you add a test? |
|
Yes. That's a great idea. I'll give it a go. |
johansmitsnl
added a commit
that referenced
this pull request
Jul 31, 2018
* Deliver root mail (Closes: #952) * don't update permissions on non-existent file (Closes: #956) * Update docker-configomat (Closes: #959) * Support for detecting running container mount (Closes: #884) * Report sender (Closes: #965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (Closes: #979, #980) * fix SASL domain (Closes: #892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (Closes: #989)
johansmitsnl
added a commit
that referenced
this pull request
Jul 31, 2018
Release 6.1.0 * Deliver root mail (#952) * don't update permissions on non-existent file (#956) * Update docker-configomat (#959) * Support for detecting running container mount (#884) * Report sender (#965) added REPORT_SENDER env variable to the container. * Add saslauthd option for ldap_start_tls & ldap_tls_check_peer - (#979, #980) * fix SASL domain (#892, #970) * DOMAINNAME can fail to be set in postsrsd-wrapper.sh (#989)
11 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the container doesn’t have a proper hostname, postsrsd will fail to start
because SRS_DOMAIN is empty. Make a best effort to figure out the domain name
and provide a way to set one if needed.