there is a bug in the @since tag parser... #320

Closed
holex opened this Issue Feb 24, 2013 · 1 comment

Projects

None yet

2 participants

@holex
holex commented Feb 24, 2013

I'm pretty sure there would be a bug in the GBCommentProcessor class.

The affected method is the following:

- (BOOL)processAvailabilityBlockInString:(NSString *)string lines:(NSArray *)lines blockRange:(NSRange)blockRange shortRange:(NSRange)shortRange

The affected line is that:

NSString *description = [components count] > 3 ? [components objectAtIndex:3] : @"";

The point is, after parsing the components always has 3 or less elements, so the description will be always an empty string @"", instead of the real description.

It seems replacing the number 3 with 2 solves this issue, so with the following line the output contains the expected result finally.

NSString *description = [components count] > 2 ? [components objectAtIndex:2] : @"";

Thank you!

Owner
tomaz commented Feb 25, 2013

Yea, looks like a bug, thanks... Am fixing it right now, will push it to GitHub.

@tomaz tomaz added a commit that closed this issue Feb 25, 2013
@tomaz Fixed @since processing. Closes #320. 040c578
@tomaz tomaz closed this in 040c578 Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment