Year and update moment not replaced correctly #49

Closed
PrimaryFeather opened this Issue Jan 13, 2011 · 7 comments

Comments

Projects
None yet
2 participants

I think you mixed up "%" and "$" somewhere in the latest version. Because of that, the replacement of the year and change moment labels at the bottom of the HTML documents does not work.

The documentation also shows "$" instead of "%" in the documentation (section: "Prepare documentation set for publishing").

Owner

tomaz commented Jan 13, 2011

Yes, I was forced to change this because DDCli (or underlying options parser) removed any text prefixed with $ from command line, hence making this --docset-feed-url http://gentlebytes.com/downloads/$DOCSETATOMFILENAME useless as appledoc only received http://gentlebytes.com/downloads as the value. After experimenting a bit, I noticed that % was properly passed through, so I switched. I wasn't particuarly happy about it, but found no other quick solution...

I updated online documentation with new syntax, but must have forgoten publishing section - will keep this issue open until I fix that.

See commit 45159f0638055aaee611 for details.

Owner

tomaz commented Jan 13, 2011

Aha, didn't notice template error, this is a bug, will fix it ASAP.

No problem! I just wanted to be sure you're aware of that.
Thanks!

Owner

tomaz commented Jan 13, 2011

I'm on it right now, will also update documentation while at the subject :) Thanks for pointing it out. This part would also benefit from being covered with unit tests to prevent issues like this in the future, will see if it can be easily covered.

Owner

tomaz commented Jan 13, 2011

Fixed HTML footer year and last update strings. Closed by f18465e.

This was broken when switching from $ to % in commit 45159f0. Forgot to check it then.

Owner

tomaz commented Jan 13, 2011

Also update online documentation...

Great, thank you!

@tonklon tonklon pushed a commit to tonklon/appledoc that referenced this issue Mar 8, 2012

@tomaz tomaz Fixed HTML footer year and last update strings. Closes #49.
This was broken when switching from $ to % in commit 45159f0. Forgot to check it then.
f18465e

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment