Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fix crash when making cross reference from static markdown document #203

Merged
merged 1 commit into from Mar 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

jonklein commented Mar 10, 2012

I have a reproducable crash being triggered by a cross reference from a static markdown document to a documented source class (I can provide an archive which demonstrates the problem if needed). The code which prevents cross references to the current entity does not work correctly in the context of a GBDocumentData object.

It looks like the isCrossReference:matchingObject: code is implicitly assuming a GBMethodData in this case, so checking for GBDocumentData addresses the issue. However, it might be preferable to use another mechanism like respondsToSelector: if there are other kinds of objects that can fall through to this case -- I don't know enough about the appledoc design here to say which is best, but I can make that change if you'd prefer.

Owner

tomaz commented Mar 10, 2012

Hm, strange nobody came accross this yet... Thanks, am merging it right now..

@tomaz tomaz added a commit that referenced this pull request Mar 10, 2012

@tomaz tomaz Merge pull request #203 from jonklein/master
Fix crash when making cross reference from static markdown document. Closes #203.
e19b1b7

@tomaz tomaz merged commit e19b1b7 into tomaz:master Mar 10, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment