Quoted PROJECT_DIR in build-step to handle paths that contain spaces or shell-characters #267

Merged
merged 1 commit into from Oct 29, 2012

Conversation

Projects
None yet
2 participants
@rfl-eqatec
Contributor

rfl-eqatec commented Oct 29, 2012

The PROJECT_DIR environment variable was used without quotes in a build-step. This would cause problems if the path where the project was stored contained spaces or shell-characters.
The solution is to always enclose variables with quotes "" if they are being used as path/file arguments.

@rfl-eqatec

This comment has been minimized.

Show comment Hide comment
@rfl-eqatec

rfl-eqatec Oct 29, 2012

Owner

The PROJECT_DIR environment variable was used without quotes in a build-step. This would cause problems if the path where the project was stored contained spaces or shell-characters.
The solution is to always enclose variables with quotes "" if they are being used as path/file arguments.

Owner

rfl-eqatec commented on 03de84c Oct 29, 2012

The PROJECT_DIR environment variable was used without quotes in a build-step. This would cause problems if the path where the project was stored contained spaces or shell-characters.
The solution is to always enclose variables with quotes "" if they are being used as path/file arguments.

@tomaz

This comment has been minimized.

Show comment Hide comment
@tomaz

tomaz Oct 29, 2012

Owner

Thanks, merging right now.

Owner

tomaz commented Oct 29, 2012

Thanks, merging right now.

tomaz added a commit that referenced this pull request Oct 29, 2012

Merge pull request #267 from rfl-eqatec/master
Quoted PROJECT_DIR in build-step to handle paths that contain spaces or shell-characters

@tomaz tomaz merged commit 6abd243 into tomaz:master Oct 29, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment