Adding support for multiple feed formats #309

Merged
merged 2 commits into from Feb 7, 2013

Projects

None yet

2 participants

@bjtitus
Contributor
bjtitus commented Feb 6, 2013

This is some initial support for adding Dash xml feed generation (#307). Note that support for specifying formats is a little crude and I've added a template for xml files which I think is a reasonable approach.

Basically, I've added a --docset-feed-formats which currently takes a series separated by commas with current types being atom and xml. and --docset-xml-filename to allow users to specify multiple feed formats and the corresponding filename to go with the xml feed. It might be better to just have a --docset-feed-filename and append the extension according to the format.

The other change is related to the --docset-package-filename which will now ignore the path extension and create the file with the appropriate extension depending on which format is being output. I realize this might cause issues if people are relying on being able to change the extension through this argument but this seemed like the best way to do it without adding filenames for each format.

The xml file template Templates/publish/xml-template.xml allows users to create their own templates in case Dash or anyone else has a different format. I thought this should be made available since it's mostly static anyway.

I'm not totally sold on how it's recognizing the feed formats but I think it's better than nothing.

This will default to Atom so that existing functionality will work.

bjtitus added some commits Feb 5, 2013
@bjtitus bjtitus Adding support for generating Dash's xml format #307
This is some initial support for adding Dash xml feed generation. Note that support for specifying formats is a little crude and I've added a template for xml files which I think is a reasonable approach.
75a3907
@bjtitus bjtitus Removing old todo and displaying proper output paths f5c9ef1
@tomaz
Owner
tomaz commented Feb 7, 2013

Cool, thanks! Merging it right away...

@tomaz tomaz merged commit 3377667 into tomaz:master Feb 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment