Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes a bug causing the xar-file URL to be incorrect #339

Merged
merged 2 commits into from Mar 13, 2013

Conversation

Projects
None yet
2 participants
Contributor

odrobnik commented Mar 13, 2013

This causes problems since there is not supposed to be an extension anyway. Removing an extension from DTCoreText-1.2 causes the package name to be become DTCoreText-1.xar which is wrong.

Fixes #338

odrobnik added some commits Mar 13, 2013

Removed superfluous removing of extension.
This causes problems since there is not supposed to be an extension anyway. Removing an extension from DTCoreText-1.2 causes the package name to be become DTCoreText-1.xar which is wrong.

Fixes #338
Add the .xar extension to the enclosure URL if necessary
Fixes #338

The extension xar is added to the output file path for the docset utility, but it is not checked that it is in the url. Without this there is a scenario where the URL is missing the extension.

@odrobnik odrobnik referenced this pull request in Cocoanetics/DTCoreText Mar 13, 2013

Closed

Installing documentation in XCode with atom feed doesn't work #337

tomaz added a commit that referenced this pull request Mar 13, 2013

Merge pull request #339 from Cocoanetics/atomurlfix
Fixes a bug causing the xar-file URL to be incorrect

@tomaz tomaz merged commit 049e3a8 into tomaz:master Mar 13, 2013

Owner

tomaz commented Mar 13, 2013

Merged, thanks again!

fbronner pushed a commit to fbronner/appledoc that referenced this pull request Apr 30, 2013

Revert "Merge pull request #339 from Cocoanetics/atomurlfix"
This reverts commit 049e3a8, reversing
changes made to 81cf405.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment