converted testing test asserts to pytest #4949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
commented
Mar 9, 2017
| @@ -200,8 +200,8 @@ def test_empty_post_uses_default_boolean_value(self): | |||
| data=None, | |||
| content_type='application/json' | |||
| ) | |||
| self.assertEqual(response.status_code, 200, response.content) | |||
| self.assertEqual(response.data, {"flag": True}) | |||
There was a problem hiding this comment.
how this should be formatted?
There was a problem hiding this comment.
Third arg there is for an optional msg according to docs. I think we can just drop it. I don't think we do that anywhere else.
adamchainz
reviewed
Mar 23, 2017
There was a problem hiding this comment.
@auvipy are you doing this with unittest2pytest ? https://github.com/pytest-dev/unittest2pytest
|
no but I think I will use it next |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.