Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address feedback #13

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
2 participants
@tomerd
Copy link
Owner

commented Apr 5, 2019

motivation: address feedback from community, prepare for moving api to official repo

changes:

  • add reset method to counter
  • do not force the user facing metric object to implement the mteric handler protocol. this was done for convinience and confuses matters
  • adjust tests
  • fix a few typos
address feedback
motivation: address feedback from community, prepare for moving api to official repo

changes:
* add reset method to counter
* do not force the user facing metric object to implement the mteric handler protocol. this was done for convinience and confuses matters
* adjust tests
* fix a few typos

@tomerd tomerd requested review from ktoso and weissi Apr 5, 2019

@tomerd

This comment has been minimized.

Copy link
Owner Author

commented Apr 5, 2019

}

// This is the user facing Counter API. Its behavior depends on the `CounterHandler` implementation
public class Counter: CounterHandler {
public class Counter {

This comment has been minimized.

Copy link
@ktoso

ktoso Apr 5, 2019

Collaborator

👍

@ktoso

ktoso approved these changes Apr 5, 2019

Copy link
Collaborator

left a comment

LGTM

@tomerd tomerd merged commit 187653d into master Apr 5, 2019

@tomerd tomerd deleted the fixes1 branch Apr 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.