Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SocketStream: add support for unix domain sockets #100
Added client, server and a test.
The server code isn't very pretty as it was highly oriented to networking. I didn't want to make a bigger refactoring as it won't be backward compatible (and I'd be happy to see it in 3.2).
It'd be perfectly fine if you decide not to merge.. I can offer a prettier solution to 3.3 (specifically add separate constructors to the Server class instead of tons of mutually exclusive arguments)
i'm going to release 3.2.3 next week so i incorporated it despite my reservations. on the other hand, i don't want to break backwards compatibility for the 3.2 branch, so i decided to live with it. for 3.3 i'll prolly rewrite it.
you're right about the ipv6. I was in the mood of comparing all values to their defaults for some reason.
I wonder what are your thoughts about function arguments default values. I usually set them to None always. that way I can always compare to None to see if a user has set a value, and even more important factory functions that just call the same function don't need to copy it's return values.
then again, if it was easy to extract defaults it could be a different ball game:
go ahead and send a patch to python :)
i'm all for factory methods. i wanted to add
On Tue, Nov 27, 2012 at 12:50 PM, Alon Horev firstname.lastname@example.org:
- Fix refcount leakage when unboxing from cache (#196) - Fix TypeError when dispatching exceptions on py2 (unicode) - Respect ``rpyc_protocol_config`` for default Service getattr (#202) - Support unix domain sockets (#100,#208) - Use first accessible server in ``connect_by_service`` (#220) - Fix deadlock problem with logging (#207,#212)