New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a race condition where a reply is received before setting the callback... #136

Merged
merged 1 commit into from Jul 7, 2014

Conversation

Projects
None yet
2 participants
@fviard
Contributor

fviard commented Jul 7, 2014

... on an async request to handle it.

In such a case, rpyc would treat the early reply as if it was a reply for a sync request, and so the async request will be stuck till encountering a timeout
The callback needs to be registered before sending the request.

Fix a race condition where a reply is received before setting the cal…
…lback on an async request to handle it.

In such a case, rpyc would treat the early reply as if it was a reply for a sync request, and so the async request will be stuck till encountering a timeout
The callback needs to be registered before sending the request.
@tomerfiliba

This comment has been minimized.

Owner

tomerfiliba commented Jul 7, 2014

Looks good. Thanks!

tomerfiliba added a commit that referenced this pull request Jul 7, 2014

Merge pull request #136 from fviard/fix_racecondition
Fix a race condition where a reply is received before setting the callback...

@tomerfiliba tomerfiliba merged commit 457985e into tomerfiliba:master Jul 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment