Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further fixes unveiled after fix for bug #182 #191

Merged
merged 2 commits into from May 29, 2017

Conversation

@glpatcern
Copy link
Contributor

glpatcern commented Mar 31, 2016

Hi Tomer,

I have found a couple of bugs unveiled after my fix for calling poll() from lib/compat instead of select(). The change in compat.py is self-explanatory.
At the same time, we have been chasing socket leaks in the ThreadedPoolServer class and you may want to include that patch as well.

Cheers,
Giuseppe

glpatcern added 2 commits Mar 22, 2016
The bug in compat.py was unveiled after fixing bug #182 and observing spinning processes. After that, the poll() call in server.py became too slow (1s instead of 1ms), leading to timeouts. The new value allows for not spinning too fast yet reacting quickly to new incoming connections.
@glpatcern glpatcern force-pushed the glpatcern:master branch 3 times, most recently from 98cd813 to 12544f4 Mar 31, 2016
@glpatcern glpatcern changed the title Further fix unveiled after fix for bug #182 Further fixes unveiled after fix for bug #182 Mar 31, 2016
@coldfix coldfix merged commit 057b3d1 into tomerfiliba:master May 29, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coldfix added a commit that referenced this pull request Jun 9, 2017
* Fix issue high-cpu polling (#191,#218)
* Fix filename argument in logging (#197)
* Improved log messages (#191,#204)
* Drop support for python 3.2 and py 2.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.