Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Bug fix for on exiting a remote context-manager with exception #228
When exiting a remote context-manager due to an exception, rpyc will attempt to pass the
Thanks for your contributions! I have a few minor comments.
Hi @koreno, I will merge your PR if you clarify the following:
(I had asked this before, but it was attached to a outdated diff, so I'm not sure you saw my query)
To clarify, is this PR a fix for locally raising an exception within the context of a remote context manager, or a fix for remotely reraising it from within the
If the first one is the case, this test should be simplified as I suggested.
where the suggestion was:
There is two things wrong here:
I think the test should look like this:
and remove the
The test I've added, in its final version, indeed matches what you've suggested.
Hm. I see I misunderstood your comment.
Why is that? a python traceback clearly indicates from which line an exception got thrown.