Should expires header also be set #20

Open
serby opened this Issue Jan 4, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@serby
Contributor

serby commented Jan 4, 2012

ySlow speed is complaining about expires headers not being set.

Should gzippo have an option to set this as well as cache-control?

@tomgco

This comment has been minimized.

Show comment
Hide comment
@tomgco

tomgco Jan 4, 2012

Owner

It does currently set the expires header however only to one day. It is a bug and should be defaulted to one week.

Owner

tomgco commented Jan 4, 2012

It does currently set the expires header however only to one day. It is a bug and should be defaulted to one week.

@tomgco

This comment has been minimized.

Show comment
Hide comment
@tomgco

tomgco Jan 4, 2012

Owner

It seems that Connect doesn't implement support for the Expires header: senchalabs/connect#410 however gzippo does for gzipped content.

Owner

tomgco commented Jan 4, 2012

It seems that Connect doesn't implement support for the Expires header: senchalabs/connect#410 however gzippo does for gzipped content.

@serby

This comment has been minimized.

Show comment
Hide comment
@serby

serby Jan 4, 2012

Contributor

Yeah, I saw that you do it for gzipped content. But adding it to
pass() before deferering to connect's staticSend would mean a few
extra points on PageSpeed/ySlow.

Yet another reason to use gzippo as your static middleware!

On 4 January 2012 14:02, Tom Gallacher
reply@reply.github.com
wrote:

It seems that Connect doesn't implement support for the Expires header: senchalabs/connect#410 however gzippo does for gzipped content.


Reply to this email directly or view it on GitHub:
https://github.com/tomgallacher/gzippo/issues/20#issuecomment-3354820

paul.serby@clock.co.uk
Chief Technology Officer

Direct: +44 2030 516115
Mobile: +44 7881 550999
Conference: +44 20 3051 6144

Clock Limited
The Old School House
Bridge Road, Hunton Bridge,
Kings Langley, WD4 8RQ
Switchboard: +44 1923 261166

www.clock.co.uk

http://twitter.com/clock
http://blog.clock.co.uk/
http://delicious.com/clocklimited

www.clock.co.uk/email-disclaimer

clock.® is a Registered Trademark of Clock Limited in the European
Community and other territories

Contributor

serby commented Jan 4, 2012

Yeah, I saw that you do it for gzipped content. But adding it to
pass() before deferering to connect's staticSend would mean a few
extra points on PageSpeed/ySlow.

Yet another reason to use gzippo as your static middleware!

On 4 January 2012 14:02, Tom Gallacher
reply@reply.github.com
wrote:

It seems that Connect doesn't implement support for the Expires header: senchalabs/connect#410 however gzippo does for gzipped content.


Reply to this email directly or view it on GitHub:
https://github.com/tomgallacher/gzippo/issues/20#issuecomment-3354820

paul.serby@clock.co.uk
Chief Technology Officer

Direct: +44 2030 516115
Mobile: +44 7881 550999
Conference: +44 20 3051 6144

Clock Limited
The Old School House
Bridge Road, Hunton Bridge,
Kings Langley, WD4 8RQ
Switchboard: +44 1923 261166

www.clock.co.uk

http://twitter.com/clock
http://blog.clock.co.uk/
http://delicious.com/clocklimited

www.clock.co.uk/email-disclaimer

clock.® is a Registered Trademark of Clock Limited in the European
Community and other territories

@mitar

This comment has been minimized.

Show comment
Hide comment
@mitar

mitar Feb 12, 2013

Hm, I do see expires header in current version?

mitar commented Feb 12, 2013

Hm, I do see expires header in current version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment