spaces in file name fails when used express or meteor #37

Closed
limeyd opened this Issue Jun 11, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@limeyd

limeyd commented Jun 11, 2012

I couldn't get your tests to run so here is the offending line.

var gzippo = function(filename, charset, callback) {

    fs.readFile(filename, function (err, data) {
...

sholud be...

var gzippo = function(filename, charset, callback) {

    fs.readFile(decodeURI(filename), function (err, data) {
...

tomgco added a commit that referenced this issue Jun 20, 2012

@tomgco tomgco closed this Jun 20, 2012

@tomgco

This comment has been minimized.

Show comment Hide comment
@tomgco

tomgco Jun 20, 2012

Owner

Thanks! Not sure why they are not running, when node 0.8 arrives I think a rewrite is needed.

Owner

tomgco commented Jun 20, 2012

Thanks! Not sure why they are not running, when node 0.8 arrives I think a rewrite is needed.

tomgco added a commit that referenced this issue Jul 18, 2012

Fixing #37
Conflicts:

	lib/staticGzip.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment