Fixes 404 when request header Accept-Encoding not set #48

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants

When static middleware is enabled, sending a request without
Accept-Encoding set would cause a premature call to pass()
before checking if the requested file exists. This meant that
calls to normal Express routes would be intercepted and result
in 404s.

This pull request addresses the Issue detailed here:
#47

underbluewaters added some commits Dec 7, 2012

@underbluewaters underbluewaters Fixes 404 when request header Accept-Encoding not set
When static middleware is enabled, sending a request without
Accept-Encoding set would cause a premature call to pass()
before checking if the requested file exists. This meant that
calls to normal Express routes would be intercepted and result
in 404s.
10d1817
@underbluewaters underbluewaters Fixed "gzippo.staticGzip should redirect on directories" feeef9b

Anything I can do to help move this along?

fent commented Feb 6, 2013

+1

swang commented Feb 7, 2013

👍 Would like to see this merged and also to have the code updated

arscan commented Apr 18, 2013

👍

gtracy commented Dec 2, 2013

curious why this change hasn't been incorporated yet?

SLaks commented Dec 2, 2013

@gtracy If you look at the commit history, this repo appears to have been abandoned for about a year.

gtracy commented Dec 2, 2013

There's no shortage of installations via NPM so there is plenty of interest in it. And without this fix, it can't be used in some use cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment