Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make focus style visible in nav for keyboard navigation #181

Merged
merged 1 commit into from Mar 28, 2021

Conversation

@ktbee
Copy link
Contributor

@ktbee ktbee commented Oct 27, 2019

Hello, thank you for making such a fully featured theme available! One accessibility issue I noticed that that it is hard to use keyboard navigation with this theme because it's not clear when a nav element is in focus. I am submitting a couple of small CSS changes that help with focus styling, including removing the outline: 0 styling from other nav elements as well (more info here).

Looking forward to your thoughts on this and thanks again for providing this theme.

Example of navbar item ("News") with focus styling

Screen Shot 2019-10-27 at 12 28 03 PM

Example of nav item that has focus ("Supported features") and doesn't have its default browser styling removed from outline: 0

Screen Shot 2019-10-27 at 12 28 27 PM

@tomjoht tomjoht merged commit c26522a into tomjoht:gh-pages Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants