Make focus style visible in nav for keyboard navigation #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for making such a fully featured theme available! One accessibility issue I noticed that that it is hard to use keyboard navigation with this theme because it's not clear when a nav element is in focus. I am submitting a couple of small CSS changes that help with focus styling, including removing the
outline: 0styling from other nav elements as well (more info here).Looking forward to your thoughts on this and thanks again for providing this theme.
Example of navbar item ("News") with focus styling
Example of nav item that has focus ("Supported features") and doesn't have its default browser styling removed from
outline: 0