Skip to content
Permalink
Branch: master
Find file Copy path
Find file Copy path
Fetching contributors…
Cannot retrieve contributors at this time
46 lines (31 sloc) 2.85 KB

Adding a new scraper type

This guide walks you through the process of adding a new scraper type.


📢 Before implementing a new scraping type, please open an issue to discuss your scenario


Configuration

  1. Add your new scraping type to the Promitor.Core.Scraping.Configuration.Model.ResourceType
  2. Describe the resource for which you're creating scraping metrics by creating <New-Type>MetricDefinitionand inherit from Promitor.Core.Scraping.Configuration.Model.Metrics.MetricDefinition - this class should go in .\src\Promitor.Core.Scraping\Configuration\Model\Metrics\ResourceTypes
  3. Create a new Deserializer in .\src\Promitor.Core.Scraping\Configuration\Serialization\Deserializers. This must inherit from GenericAzureMetricDeserializer.
  4. Update Promitor.Core.Scraping.Factories.MetricDeserializerFactory to handle your new resource type by returning a new instance of the Deserializer you created in the previous step.
  5. Provide a unit test in .\src\Promitor.Scraper.Tests.Unit\Serialization\MetricsDeclaration\ that tests the deserialization based on our sample

Going forward in this guide, TMetricDefinition will refer to your newly created configuration type.

Validation

For every scraper type we provide validation for the configuration so that Promitor fails to start up.

This requires the following steps:

  1. Create a new validator that implements MetricValidator<TMetricDefinition> where TMetricDefinition is the definition you made in step #2 above. This validator should reside in .\src\Promitor.Scraper.Host\Validation\MetricDefinitions\ResourceTypes. You can look at the contents of ServiceBusQueueMetricValidator for an idea of the validation inputs, steps, and outputs typical of validator implementation.
  2. Add construction and usage of this validator to .\src\Promitor.Scraper.Host\Validation\Factories\MetricValidatorFactory.cs for the ResourceType you created in step #1 above.
  3. Provide a unit test for every validation rule that was added in .\src\Promitor.Scraper.Tests.Unit\Validation\Metrics\ResourceTypes

Scraping

  1. Implement a scraper that inherits from Scraper<TMetricDefinition>. This one will specify how to call Azure Monitor.
  2. Hook your new scraper in our MetricScraperFactory which determines what scraper to use for the passed configuration

📝 Currently we don't have integration tests


Documentation

Features are great to have but without clear & well-written documentation they are somewhat useless.

It would be good if you could provide documentation on the following:

  1. What Azure service it supports and how to use it
  2. What fields need to be configured and what they are for
  3. An example configuration

This should be provided in a new file under docs\configuration\metrics.

You can’t perform that action at this time.