Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better guidance for misconfigured Azure metrics #1426

Open
tomkerkhove opened this issue Dec 23, 2020 · 0 comments
Open

Provide better guidance for misconfigured Azure metrics #1426

tomkerkhove opened this issue Dec 23, 2020 · 0 comments
Labels
agents:scraper All issues related to the scraping agent enhancement Enhancements for current features Hacktoberfest All issues available for contribution during Hacktoberfest help-wanted All issues where people can contribute to the project

Comments

@tomkerkhove
Copy link
Owner

tomkerkhove commented Dec 23, 2020

Provide better guidance for misconfigured Azure metrics, for example an unsupported dimension name.

For example:

[20:50:00 FTL] Failed to scrape resource for metric 'azure_response_status'
Microsoft.Azure.Management.Monitor.Fluent.Models.ErrorResponseException: Operation returned an invalid status code 'BadRequest'
at Microsoft.Azure.Management.Monitor.Fluent.MetricsOperations.ListWithHttpMessagesAsync(String resourceUri, ODataQuery1 odataQuery, String timespan, Nullable1 interval, String metricnames, String aggregation, Nullable1 top, String orderby, Nullable1 resultType, String metricnamespace, Dictionary2 customHeaders, CancellationToken cancellationToken) at Microsoft.Azure.Management.Monitor.Fluent.MetricsOperationsExtensions.ListAsync(IMetricsOperations operations, String resourceUri, ODataQuery1 odataQuery, String timespan, Nullable1 interval, String metricnames, String aggregation, Nullable1 top, String orderby, Nullable1 resultType, String metricnamespace, CancellationToken cancellationToken) at Microsoft.Azure.Management.Monitor.Fluent.Models.MetricDefinitionImpl.ExecuteAsync(CancellationToken cancellationToken) at Microsoft.Azure.Management.Monitor.Fluent.Models.MetricDefinitionImpl.Microsoft.Azure.Management.Monitor.Fluent.IWithMetricsQueryExecute.ExecuteAsync(CancellationToken cancellationToken) at Promitor.Integrations.AzureMonitor.AzureMonitorClient.GetRelevantMetric(String metricName, AggregationType metricAggregation, TimeSpan metricInterval, String metricFilter, String metricDimension, IMetricDefinition metricDefinition, DateTime recordDateTime) in /src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs:line 150 at Promitor.Integrations.AzureMonitor.AzureMonitorClient.QueryMetricAsync(String metricName, String metricDimension, AggregationType aggregationType, TimeSpan aggregationInterval, String resourceId, String metricFilter) in /src/Promitor.Integrations.AzureMonitor/AzureMonitorClient.cs:line 82 at Promitor.Core.Scraping.AzureMonitorScraper1.ScrapeResourceAsync(String subscriptionId, ScrapeDefinition1 scrapeDefinition, TResourceDefinition resourceDefinition, AggregationType aggregationType, TimeSpan aggregationInterval) in /src/Promitor.Core.Scraping/AzureMonitorScraper.cs:line 51 at Promitor.Core.Scraping.Scraper1.ScrapeAsync(ScrapeDefinition`1 scrapeDefinition) in /src/Promitor.Core.Scraping/Scraper.cs:line 69
[20:50:00 FTL] Operation returned an invalid status code 'BadRequest'

Should be enhanced so that it contains a link to https://docs.microsoft.com/en-us/azure/azure-monitor/platform/metrics-supported#microsoftnetworkapplicationgateways to find the correct dimension and, optionally, corresponding Promitor docs. This should be retrieved through every scraper that provides the link as a property.

@tomkerkhove tomkerkhove added enhancement Enhancements for current features help-wanted All issues where people can contribute to the project agents:scraper All issues related to the scraping agent labels Dec 23, 2020
@tomkerkhove tomkerkhove added this to the Scraper - v2.1.0 milestone Jan 6, 2021
@tomkerkhove tomkerkhove removed this from the Scraper - v2.2.0 milestone Mar 11, 2021
@tomkerkhove tomkerkhove moved this to Proposed in Promitor Roadmap May 17, 2022
@tomkerkhove tomkerkhove added the Hacktoberfest All issues available for contribution during Hacktoberfest label Sep 26, 2022
@tomkerkhove tomkerkhove moved this from Proposed to Todo in Promitor Roadmap Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents:scraper All issues related to the scraping agent enhancement Enhancements for current features Hacktoberfest All issues available for contribution during Hacktoberfest help-wanted All issues where people can contribute to the project
Projects
Status: Todo
Development

No branches or pull requests

1 participant