Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide information about dependencies in health endpoint #222

Open
tomkerkhove opened this issue Nov 14, 2018 · 2 comments
Milestone

Comments

@tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Nov 14, 2018

Provide detailed information about the health of scraper and its dependencies in health endpoint.

Specification

Tasklist

  • Provide insights on our dependencies
    • Azure Monitor (can we auth/communicate with it)
  • Reflect feature in documentation

API Specs

The response should follow the built-in ASP.NET HealthCheckResult.

Considerations

  • Determine if we should include validation of configuration here or if the startup is enough?
    • For example, we could corrupt our config via the changing the ConfigMap in Kubernetes.
@tomkerkhove

This comment has been minimized.

Copy link
Owner Author

@tomkerkhove tomkerkhove commented Mar 11, 2019

The endpoint should be in line with Microsoft Health Check Guidance

@tomkerkhove

This comment has been minimized.

Copy link
Owner Author

@tomkerkhove tomkerkhove commented Jul 3, 2019

We should use AspNetCore.Diagnostics.HealthChecks

See domaindrivendev/Swashbuckle.AspNetCore#1058 for consuming it in a Swagger documented endpoint.

@tomkerkhove tomkerkhove added this to the v1.1.0 milestone Jul 3, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.1.0, v1.2.0 Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.