Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide capability to scrape multiple subscriptions #761

Closed
tomkerkhove opened this issue Oct 30, 2019 · 6 comments · Fixed by #947
Closed

Provide capability to scrape multiple subscriptions #761

tomkerkhove opened this issue Oct 30, 2019 · 6 comments · Fixed by #947
Labels
configuration feature scraping
Milestone

Comments

@tomkerkhove
Copy link
Owner

@tomkerkhove tomkerkhove commented Oct 30, 2019

Provide capability to scrape multiple subscriptions with one scraper.

Benefits:

  • Metrics are consolidated into one configuration for multiple subs
  • Less scrapers to deploy, operate and manage

Downside(s):

  • Scraper requires access to multiple subscriptions for the same Azure AD App. This can be seen as a security concern

Interested in having this? Give it a 👍 and/or comment why you'd like to have this.

@tomkerkhove tomkerkhove added configuration scraping seeking-customer-input awaiting-customer-demand feature-not-commited labels Oct 30, 2019
@hajdukd
Copy link

@hajdukd hajdukd commented Feb 5, 2020

The same functionality used for resourceGroupName override could be reused for subscription, no ?

@tomkerkhove
Copy link
Owner Author

@tomkerkhove tomkerkhove commented Feb 5, 2020

It could, but for me it's a security boundary but it will most probably come in next couple of months so that you have the flexibility to determine this for you.

@tomkerkhove tomkerkhove added this to the v1.3.0 milestone Feb 5, 2020
@tomkerkhove tomkerkhove removed this from the v1.3.0 milestone Feb 5, 2020
@tomkerkhove tomkerkhove added this to the v1.4.0 milestone Feb 5, 2020
@tomkerkhove tomkerkhove added feature and removed awaiting-customer-demand feature-not-commited seeking-customer-input labels Feb 20, 2020
@tomkerkhove
Copy link
Owner Author

@tomkerkhove tomkerkhove commented Feb 20, 2020

We'll make it so!

@tomkerkhove tomkerkhove removed this from the v1.4.0 milestone Mar 20, 2020
@tomkerkhove tomkerkhove added this to the v1.6.0 milestone Mar 20, 2020
@tomkerkhove tomkerkhove removed this from the v1.6.0 milestone Mar 20, 2020
@tomkerkhove tomkerkhove added this to the v1.5.0 milestone Mar 20, 2020
@ahurtaud
Copy link

@ahurtaud ahurtaud commented Jun 29, 2021

Hello, I am looking at promitor and its resource-discovery. I am wondering if you would consider having auto discovery of all the subscriptions in one tenant ?

AFAIK, at the moment, in the resource-discovery-declaration.yaml, the list of subscriptions has to be set. Which makes it quite difficult in an environment where subscriptions can be created/removed quite often.

I would like this subscriptions list to be automatically discovered by the resource-discovery so that I can have automatic monitoring of 1 resource type across my tenantID.

Should I create a new feature request?

@tomkerkhove
Copy link
Owner Author

@tomkerkhove tomkerkhove commented Jun 29, 2021

Feel free to open a feature request indeed, but, this is not done by default as this has a high impact on the throttling of Azure Monitor.

How would you discover the various subscriptions? Any API you have in mind?

But like I said, feel free to open a feature request so we can track request from community.

@tomkerkhove
Copy link
Owner Author

@tomkerkhove tomkerkhove commented Jun 29, 2021

Could be discovered through Azure Resource Graph, but, Promitor would need to have access to all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration feature scraping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants