Navigation Menu

Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

New Maintainers #460

Closed
alexcrichton opened this issue Mar 1, 2022 · 16 comments
Closed

New Maintainers #460

alexcrichton opened this issue Mar 1, 2022 · 16 comments

Comments

@alexcrichton
Copy link
Collaborator

I personally no longer have the time or energy to maintain this crate. I believe this is still pretty widely used as the default TOML implementation for Rust, however, so it'd be good to keep this maintained. I'm opening this to see if there is another who is willing to take over ownership and maintenance of this crate. In the meantime I will not be maintaining this crate other than if a security issue arises.

@thomcc
Copy link

thomcc commented Apr 24, 2022

I can maintain it if nobody wants to, but largely I would probably just be reviewing/merging PRs and needed to keep up with changes to the TOML spec (which I suppose means some number of updates out of the bat to get to toml 1.0). That is, it wouldn't be that active of maintenance (although I probably would make some changes like no_std support and such).

@djc
Copy link

djc commented Apr 26, 2022

I can also help with (mostly passively) maintaining this.

@decathorpe
Copy link

I'm already maintaining the Fedora Linux RPM package for this crate, so I can help maintaining the "upstream" project, as well.

@epage
Copy link
Member

epage commented Jun 22, 2022

@alexcrichton what if we moved toml_edit::easy into toml?

A task I've been meaning to get to is to restructure toml_edit so a subset can more easily show up in public APIs, like cargo_metadata including toml. One possible route for that is to split toml_edit::easy out into its own crate and not expose any toml_edit types.

The downside being that toml_edit::easy has a ceiling on how fast it can get due to the format-preserving core its built on, even if the performance right now is roughly on par with toml.

passcod added a commit to passcod/cargo-binstall that referenced this issue Jul 23, 2022
The toml crate is unmaintained, and may be replaced with toml_edit::easy anyway:
toml-rs/toml-rs#460 (comment)
passcod added a commit to passcod/cargo-binstall that referenced this issue Jul 23, 2022
The toml crate is unmaintained, and may be replaced with toml_edit::easy anyway:
toml-rs/toml-rs#460 (comment)
@TheRustifyer
Copy link

@alexcrichton are you still looking for someone that wants to take care about the project?

@alexcrichton
Copy link
Collaborator Author

Yes I ostensibly am still looking for an interested maintainer. At this point though I would prefer to just hand the reins to someone else and not really be that involved. I'd rather not need to work in an advisory status where I still have to double-check on changes or such.

@tshepang
Copy link
Contributor

one option is donating to rust-lang org... libs team is forming a team to take care of such central crates

@tarcieri
Copy link

tarcieri commented Sep 21, 2022

@alexcrichton any thoughts on @epage’s proposal to allow the API-compatible toml_edit::easy implementation to be published as the toml crate? It’s designed to be a drop-in replacement.

@alexcrichton
Copy link
Collaborator Author

I don't personally know enough about toml_edit::easy to make a judgement call on that, and I'm not really in a position to do that myself. I basically need someone to step up and take the lead on this. If @epage you'd like to do that I'm happy to transfer the crate to you.

@epage
Copy link
Member

epage commented Sep 21, 2022

Yes, I'd be willing to take that on.

Before changing out the guts, I feel like a once-over will be needed to double check it meets toml-rs's quality needs.

toml-rs/toml#327 might also be a blocker for swapping over; I haven't decided yet and am open for input.

For anyone else interested in the level of compatibility, these are the two PRs for switching cargo from toml to toml_edit::easy

@alexcrichton
Copy link
Collaborator Author

Ok, thanks! When you're satisfied I'm happy to add you to crates.io and leave a tombstone in this repository's README or similar.

@epage
Copy link
Member

epage commented Sep 22, 2022

@alexcrichton if a gradual approach is fine with you've, we've gone ahead and merged the toml-rs repo into toml_edit and created https://github.com/toml-rs for hosting this and the rust wrapper around toml-test.

@alexcrichton
Copy link
Collaborator Author

Thanks! Would you like me to transfer this repo to that org for posterity or just update the README?

@epage
Copy link
Member

epage commented Sep 23, 2022

Either works for me

@alexcrichton
Copy link
Collaborator Author

Ok I've sent a transfer request for this repo to you and I've added you to crates.io

@epage
Copy link
Member

epage commented Sep 23, 2022

Looks like we're all good now; closing this out

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants