Collapsing changes

[stevenleeg]

I've been loving HackerNew since I installed it, but one thing I missed was reddit-like comment collapsing from a plugin I was previously using called Hacker News Collapse.

This pull request implements HN Collapse in HackerNew. It's quite a bit less showy than the current implementation, but I think it does a good job of making comment collapsing fast and easily accessible.

Here's what it looks like before:

And after:

Let me know what you think!

[tommoor]

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

[tommoor]

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

[stevenleeg]

Ah to each his own. It's mostly a visual tweak (check out the diff), so if you don't want to include it feel free to close this.

Keep up the awesome job on HackerNew!

On Tue, Mar 12, 2013 at 1:30 AM, Tom Moor notifications@github.com
wrote:

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

Reply to this email directly or view it on GitHub:
#11 (comment)

[stevenleeg]

Ah to each his own. It's mostly a visual tweak (check out the diff), so if you don't want to include it feel free to close this.

Keep up the awesome job on HackerNew!

On Tue, Mar 12, 2013 at 1:30 AM, Tom Moor notifications@github.com
wrote:

Hey Steven,

It's probably better to have the collapse functionality over on the left, it does better associate it with the content that you're collapsing. Does this patch do anything other than change the styling, or is it just a visual tweak?

Reply to this email directly or view it on GitHub:
#11 (comment)

[christiangenco]

+1 on having it on the left side. This is how the Reddit Enhancement suite does things:

Which is super nice, because to collapse a whole bunch of comments in series you only have to move your mouse horizontally. From a design standpoint, that makes a lot more sense.

[christiangenco]

+1 on having it on the left side. This is how the Reddit Enhancement suite does things:

Which is super nice, because to collapse a whole bunch of comments in series you only have to move your mouse horizontally. From a design standpoint, that makes a lot more sense.

[tommoor]

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

[tommoor]

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

[christiangenco]

.prepend instead?

[christiangenco]

.prepend instead?

[stevenleeg]

Got it! I fixed it in 2efb623.

[christiangenco]

Woohoo!

[christiangenco]

No need to hide/show on hover if it's just [-] imo. Not that much saved space.

[christiangenco]

No need to hide/show on hover if it's just [-] imo. Not that much saved space.

[stevenleeg]

What do you mean? This isn't doing anything on hover as far as I can see.

[christiangenco]

Ahh nevermind - I misread this.

[stevenleeg]

I'm stuck in an airport for a bit so I can tweak it and see if you'd like it. Hang tight and I'll get something pushed!

On Wed, Mar 13, 2013 at 2:19 PM, Tom Moor notifications@github.com
wrote:

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

Reply to this email directly or view it on GitHub:
#11 (comment)

[stevenleeg]

I'm stuck in an airport for a bit so I can tweak it and see if you'd like it. Hang tight and I'll get something pushed!

On Wed, Mar 13, 2013 at 2:19 PM, Tom Moor notifications@github.com
wrote:

Ah interesting, I definitely feel this is a better direction than the current implementation - perhaps I could pull this and tweak it further so that the collapse is on the left.

Reply to this email directly or view it on GitHub:
#11 (comment)

[stevenleeg]

There we are:

[stevenleeg]

There we are:

[tommoor]

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

• Are the retina arrows not working for you? They look kind of crappy...
• I wonder if we can size the + and - to be the same size - perhaps use an emdash or something longer..

[tommoor]

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

• Are the retina arrows not working for you? They look kind of crappy...
• I wonder if we can size the + and - to be the same size - perhaps use an emdash or something longer..

[stevenleeg]

Glad you like it! I've been using my fork for a couple days now and haven't had any problems with the collapsing.

And yeah I've been having trouble with the retina arrows actually, not sure why. It might be some change I made so I'll look into it when I get home later.

On Wed, Mar 13, 2013 at 3:21 PM, Tom Moor notifications@github.com
wrote:

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

• Are the retina arrows not working for you? They look kind of crappy...

- I wonder if we can size the + and - to be the same size - perhaps use an emdash or something longer..

Reply to this email directly or view it on GitHub:
#11 (comment)

[stevenleeg]

Glad you like it! I've been using my fork for a couple days now and haven't had any problems with the collapsing.

And yeah I've been having trouble with the retina arrows actually, not sure why. It might be some change I made so I'll look into it when I get home later.

On Wed, Mar 13, 2013 at 3:21 PM, Tom Moor notifications@github.com
wrote:

Looking good! How are you finding it functionally? I'll be able to check it out a bit later on... two things:

• Are the retina arrows not working for you? They look kind of crappy...

- I wonder if we can size the + and - to be the same size - perhaps use an emdash or something longer..

Reply to this email directly or view it on GitHub:
#11 (comment)

[tommoor]

Merging this as it's definitely an improvment. It looks like loss of retina was related to the HN update to https the other day and is a separate issue.

[tommoor]

Merging this as it's definitely an improvment. It looks like loss of retina was related to the HN update to https the other day and is a separate issue.

[christiangenco]

Nice work @stevenleeg!

[christiangenco]

Nice work @stevenleeg!