. #33

Merged
merged 5 commits into from Aug 25, 2012

Projects

None yet

4 participants

@powder96
Contributor

No description provided.

@johannesnagl
Contributor

Breaks the Tinycon.setBubble() functionality. Always returns "undefined" as string. Please test your code against this commit: df63872

@johannesnagl
Contributor

ad 378a55b: i used js minifier, so minified output is the same as @tommoor is using. in your code the copyright comments are missing. (try to use http://fmarcia.info/jsmin/test.html with mode aggressive).

@ssokolow

@johannesnagl mishoo/UglifyJS is also good.

It's a Node.js app/library that runs quickly, is generally comparable to Closure for compression effectiveness (sometimes a bit better, sometimes a bit worse) and defaults to preserving the initial copyright comment.

@johannesnagl
Contributor

@ssokolow thx, i do know uglify works. in my own projects i use yui-compressor as textmate bundle.

in general, i try to use the same syntax/code guidelines/compression tools as the repo owner. i don't think it's useful to compress js with another tool in a pull request, which targets another problem.

so, i would fix the issue in one pull request, and minify the code with the same techniques as the repo owner. and then i would create another issue/pull request with uglify/yui-compressor or what so ever :)

@ssokolow

Fair enough.

I actually prefer to avoid YUI Compressor because not only is it written in Java (which I hate to depend on in a non-Java project) but, according to the Uglify benchmarks, it's measurably less effective than Uglify and Closure.

Of course, I'm the guy who does these, so maybe I'm just obsessed with saving bandwidth:

  • Run all JPEGs through jpegoptim
  • Run all PNGs through optipng -o7 then advpng -z4 and finally pngcrush pngcrush -rem gAMA -rem alla -rem cHRM -rem iCCP -rem sRGB -rem tim
  • Researching efficient ways to minify generated HTML in addition to just making good use of caching and HTTP cache-control headers.
  • Researching ways to minify and to non-manually simplify SVGs.
@johannesnagl
Contributor

minify all the code

@ssokolow

@powder96 Thanks. I'll have a look at that when I can spare a moment... and I'll test whether I can trigger a stack overflow with it in Python.

@tommoor
Owner
tommoor commented Aug 3, 2012

Hey guys, this looks like a great improvement - is it ready to merge into master?

@tommoor tommoor merged commit b3ecaf3 into tommoor:master Aug 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment