Doesn't work contains another "icon" string in link rel on Chrome. #36

Merged
merged 1 commit into from Nov 15, 2012

Projects

None yet

3 participants

@ussy
Contributor
ussy commented Oct 1, 2012

Chrome couldn't update a favicon.
ex) <link rel="shortcut icon" ...

It seems that link tag wasn't remove.
Because removeFaviconTag method compare "icon".

removeFaviconTag method compare

links[i].getAttribute('rel') === 'icon'

But getFaviconTag method compare string as regex.
getFaviconTag method compare

(links[i].getAttribute('rel') || '').match(/\bicon\b/)
@tommoor
Owner
tommoor commented Oct 1, 2012

Thanks! This fix makes a lot of sense, i'll get this merged in,

@manuel-84

Please release this update, it's important

@tommoor tommoor merged commit 8db1eec into tommoor:master Nov 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment