Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed double-printing the favicon #50

Merged
merged 1 commit into from

4 participants

@mllocs

The issue:

screen shot 2013-10-11 at 1 28 12 pm

I'm not sure why were you doing the double drawImage only if !browser.mozilla. Was that trying to fix an edge case that I'm not contemplating? Cheers.

@fcsonline

I had this issue too. :+1:

@tommoor
Owner

@ggPeti any thoughts on reasoning for this as it was your patch that introed? cheers!

@ggPeti

I remember having an edge case that this solved, but I don't remember what it was and I can't reproduce it now. (And I also never encountered this visual bug.)

@tommoor
Owner

I can't see any reason for the double drawing to be honest, this seems like a good fix to me.

@tommoor tommoor merged commit 7f191dc into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 11, 2013
  1. @mllocs
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 3 deletions.
  1. +2 −3 tinycon.js
View
5 tinycon.js
@@ -122,9 +122,8 @@
// clear canvas
context.clearRect(0, 0, size, size);
- // draw original favicon fallback to 16x16, then overwrite with 32x32 if possible
- context.drawImage(faviconImage, 0, 0, 16, 16, 0, 0, size, size);
- if (!browser.mozilla) context.drawImage(faviconImage, 0, 0, 32, 32, 0, 0, size, size);
+ // draw the favicon
+ context.drawImage(faviconImage, 0, 0, faviconImage.width, faviconImage.height, 0, 0, size, size);
// draw bubble over the top
if ((label + '').length > 0) drawBubble(context, label, colour);
Something went wrong with that request. Please try again.