Skip to content

Fixed double-printing the favicon #50

Merged
merged 1 commit into from Oct 11, 2013

4 participants

@mllocs
mllocs commented Oct 11, 2013

The issue:

screen shot 2013-10-11 at 1 28 12 pm

I'm not sure why were you doing the double drawImage only if !browser.mozilla. Was that trying to fix an edge case that I'm not contemplating? Cheers.

@fcsonline

I had this issue too. 👍

@tommoor
Owner
tommoor commented Oct 11, 2013

@ggPeti any thoughts on reasoning for this as it was your patch that introed? cheers!

@ggPeti
ggPeti commented Oct 11, 2013

I remember having an edge case that this solved, but I don't remember what it was and I can't reproduce it now. (And I also never encountered this visual bug.)

@tommoor
Owner
tommoor commented Oct 11, 2013

I can't see any reason for the double drawing to be honest, this seems like a good fix to me.

@tommoor tommoor merged commit 7f191dc into tommoor:master Oct 11, 2013
@mllocs
mllocs commented Oct 19, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.