Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Dropdpown menu to Frensh #91

Merged
merged 4 commits into from Nov 25, 2022

Conversation

maha-oueghlani
Copy link
Contributor

@maha-oueghlani maha-oueghlani commented Nov 15, 2022

Checklist

Please put "X" in the below checkboxes that apply::

  • If committing a bugfix, I have tested it in different browsers (Chrome, Firefox, Safari).
  • [] If committing a new feature, I have first submitted an issue (Please note: you are free to open PRs for non-issued features, but opening an issue increases your chance of a successful PR).
  • If committing a new feature, I have also written an appropriate test suite for it.

I have tested the following:

  • Qalendar component in month mode.
  • Qalendar component in week mode.
  • Qalendar component in day mode.
  • All of the above modes on emulated mobile view.
  • Dragging and dropping events.
  • Resizing events in day/week modes.
  • Clicking events to open event dialog.

This PR solves the following problem**.

Translate dropdown menu to frensh.

How to test this PR**.

  1. npm run dev
  2. change language in DevToolbar to "fr-FR"
  3. dropdown of representation mode change like this
    fr-FR

Notes

  • I didn't test effects on events because changes are not specific to events.
  • I'm not familiar with git that's why I revert the first commit, I thought that I did a mistake. But it's all good in the last commit.

@tomosterlund
Copy link
Owner

Hello there. Thank you very much for this contribution. We appreciate you taking the time to improve this library!

I started the Github actions, and will check in later for a quick review

@tomosterlund
Copy link
Owner

tomosterlund commented Nov 15, 2022

I added the last missing translation, so that all keys have a French translation. Does "+ d'autres événements" sound like a proper translation of "+ more events" to you? In that case, I'll consider the PR finished and will merge it, otherwise feel free to correct it.

@tomosterlund tomosterlund self-requested a review November 18, 2022 13:40
@tomosterlund
Copy link
Owner

I'll go ahead and merge this, and trust the Deepl-Translation for the last key. Thanks again for contributing!

@tomosterlund tomosterlund merged commit 680648c into tomosterlund:master Nov 25, 2022
@felix-berlin
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@maha-oueghlani
Copy link
Contributor Author

OK thank's for the merge. Sorry I didn't present on Github last period thats why I didn't answer you regarding the last key. But anyway it's correct :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants