-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio file sampler implementation #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I think it's finally ready to merge. A new api in the VM, let res = move |machine: &mut Machine| -> ReturnCode {
let pos = vm::Machine::get_as::<f64>(machine.get_stack(0));
// this sampler read with boundary checks.
let val = interpolate_vec(&vec, pos);
machine.set_stack(0, Machine::to_value(val));
1
};
let ty = function!(vec![numeric!()], numeric!());
let idx = machine.wrap_extern_cls(("loadwavfile_impl", Arc::new(res), ty));
machine.set_stack(0, Machine::to_value(idx));
1
}
Other next todos:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds audio file sample using symphonia crate.
This PR also introduces
ExecContext
, a pair of the compiler and VM, to manage type information of external functions.ExecContext is needed for decoupling external functions which depend on a external crates.
The PR contains an implementation of array access parser but I'm going to change the way of loading & reading wav files into that uses higher-order external function.
gen_sampler_mono
function internally creates external Rust closure that holds Vec as internal data(The allocated external closure will never be released in the current implementation. )Todo: