Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle windows with multiple root folders? #33

Closed
tomv564 opened this Issue Aug 20, 2017 · 4 comments

Comments

Projects
None yet
3 participants
@tomv564
Copy link
Owner

tomv564 commented Aug 20, 2017

The LSP package currently handles windows with multiple folders by finding a common prefix.

As discovered in #24, a common usage with Sublime workspaces is to link in whole trees of projects, perhaps even from multiple drives (e.g. C:\Users\Tom\Projects and D:\Work\)

For this scenario, it is increasingly unlikely that we can find a common prefix to give the language server as rootUri.

Looking at the language server protocol, the workspace concept (of which there is only one in a language server process) offers these actions:

workspace/symbols (would you really want to execute this across both drives ?) workspace/didChangeConfiguration (configuration is likely to be project-specific, if anything)

An improvement would be to create an LSP instance per window.folders().

Users who choose to mount the parent folder of multiple projects will have to accept that:

  • workspace symbol listing is for projects
  • The LSP package will not be able to help with per-project configuration.
@randy3k

This comment has been minimized.

Copy link
Contributor

randy3k commented Sep 14, 2017

And it should also handle the case with no folders, i.e. when editing signal files.

@tomv564

This comment has been minimized.

Copy link
Owner Author

tomv564 commented Oct 1, 2017

This has been solved by #81 (only use first folder) and #126 (support single files)

@haferburg

This comment has been minimized.

Copy link
Contributor

haferburg commented Mar 30, 2019

This issue is still mentioned on https://github.com/tomv564/LSP#troubleshooting

@tomv564

This comment has been minimized.

Copy link
Owner Author

tomv564 commented Apr 1, 2019

Thanks, pointed it to issue #81 instead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.