Skip to content

feat: add testing styleguide #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
skywardboundd wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

feat: add testing styleguide #1241

skywardboundd wants to merge 12 commits into from

Conversation

@skywardboundd
Copy link
Collaborator

@skywardboundd skywardboundd commented Nov 14, 2025

Closes #166

@skywardboundd skywardboundd linked an issue Nov 14, 2025 that may be closed by this pull request
[Ecosystem > Blueprint > Testing > Styleguide] #166
Open
@github-actions

This comment was marked as resolved.

Sign in to view
@skywardboundd
Copy link
Collaborator Author

skywardboundd commented Nov 14, 2025

https://www.youtube.com/watch?v=qgIFU98bJOQ

@skywardboundd skywardboundd marked this pull request as ready for review November 14, 2025 14:08
github-actions[bot]
github-actions bot reviewed Nov 14, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements. In contract-dev/testing/styleguide.mdx: a couple of suggestions to align tone and structure—please apply the inline suggestions.

skywardboundd and others added 2 commits November 14, 2025 17:27
@skywardboundd @github-actions
Update contract-dev/testing/styleguide.mdx
cea1677 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@skywardboundd @github-actions
Update contract-dev/testing/styleguide.mdx
ad817bd 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@anton-trunov
Copy link
Collaborator

anton-trunov commented Nov 17, 2025

/review

github-actions[bot]
github-actions bot reviewed Nov 17, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update to contract-dev/testing/styleguide.mdx; I have a couple of suggestions to align with the style guide. Please apply the inline suggestions.

verytactical
verytactical requested changes Nov 18, 2025
View reviewed changes
Copy link
Collaborator

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marketing language. We don't have time to redo this due to time constraints

@verytactical verytactical marked this pull request as draft November 18, 2025 08:15
@verytactical verytactical mentioned this pull request Nov 18, 2025
Closed
@skywardboundd skywardboundd marked this pull request as ready for review November 25, 2025 13:23
github-actions[bot]
github-actions bot reviewed Nov 25, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates to contract-dev/testing/style-guide.mdx: I have a couple of suggestions to keep the introduction direct and the gas section aligned with the neutral tone guidelines, so please apply the inline suggestions.

@skywardboundd @github-actions
Update contract-dev/testing/style-guide.mdx
7ce8000 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@skywardboundd skywardboundd marked this pull request as draft December 2, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@verytactical verytactical verytactical requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Ecosystem > Blueprint > Testing > Styleguide]

4 participants

@skywardboundd @anton-trunov @verytactical