Add size calculation method and trigger mechanism #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 14, 2024
Implemented a `size` method for `Record` and added a trigger mechanism (`Trigger`, `TriggerFactory`) to handle dynamic item insertion and manage memory efficiently. Adjusted related stream implementations and updated dependency path for `tonbo_marco`.
ethe
approved these changes
Aug 15, 2024
KKould
reviewed
Aug 15, 2024
Replaced the Count trigger type with the Length trigger type for greater specificity. Updated the TriggerFactory::create method signatures and adjusted relevant code to accommodate the new trigger type. This change helps clarify the purpose of the threshold and simplifies method usage.
Added trigger_type to DbOption to allow flexible trigger creation. Replaced the hardcoded trigger initialization in mutable.rs with the new trigger_type field from DbOption, improving maintainability and configurability.
KKould
reviewed
Aug 15, 2024
Eliminated the max_mutable_len field and its related methods from the DbOption struct, as it was redundant. Also, adjusted the trigger_type assignment to directly use the intended default value.
Implemented a trigger mechanism in the `Schema` and `Mutable` classes by integrating `TriggerFactory`. This allows the new trigger to be shared across multiple instances and ensures trigger functionality is consistently applied. Updated tests and other related modules to support this new trigger initialization.
Renamed `CountTrigger` to `LengthTrigger` and adjusted respective logic for consistency. Added tests for `SizeOfMemTrigger`, `LengthTrigger`, and `TriggerFactory` to ensure correct threshold logic and reset functionality.
KKould
reviewed
Aug 16, 2024
This change eliminates unnecessary cloning of the trigger variable in several places. By directly passing the trigger to the Mutable::new function, we simplify the code and potentially improve performance slightly.
|
Thank you @loloxwg ! I hope there are more collaborations in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a
sizemethod forRecordand added a trigger mechanism (Trigger,TriggerFactory) to handle dynamic item insertion and manage memory efficiently. Adjusted related stream implementations and updated dependency path fortonbo_marco.