New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Feature branch with Master branch #4

Merged
merged 4 commits into from Nov 16, 2015

Conversation

Projects
None yet
2 participants
@tongrhj
Owner

tongrhj commented Nov 13, 2015

@CBas My flex box currently expands to fill the viewport, but the individual tiles unfortunately change their height depending on the text content. How do I get them to expand to fill the screen, but still keep a consistent height no matter their text content?

@yongjun21 Please integrate Snake and Ping Pong into my game thanks.

@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 Nov 13, 2015 Active

@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 Nov 13, 2015 Active

display:flex;
flex-direction: row;
flex: 1;
}

This comment has been minimized.

@sebdeckers

sebdeckers Nov 13, 2015

Set them all to an equal height to override scaling based on content height.

flex-basis: 0;
@sebdeckers

This comment has been minimized.

sebdeckers commented Nov 13, 2015

Looks nice and clean 👍

@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 Nov 16, 2015 Active

@tongrhj tongrhj merged commit 6488d87 into master Nov 16, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment