Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upMerging Feature branch with Master branch #4
Conversation
tongrhj
added some commits
Nov 13, 2015
tongrhj
deployed
to
tictactoe-reborn-pr-4
Nov 13, 2015
tongrhj
deployed
to
tictactoe-reborn-pr-4
Nov 13, 2015
sebdeckers
reviewed
Nov 13, 2015
app.dist.css
Outdated
| display:flex; | ||
| flex-direction: row; | ||
| flex: 1; | ||
| } |
This comment has been minimized.
This comment has been minimized.
sebdeckers
Nov 13, 2015
Set them all to an equal height to override scaling based on content height.
flex-basis: 0;
This comment has been minimized.
This comment has been minimized.
sebdeckers
commented
Nov 13, 2015
|
Looks nice and clean |
tongrhj
deployed
to
tictactoe-reborn-pr-4
Nov 16, 2015
tongrhj
merged commit 6488d87
into
master
Nov 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
tongrhj commentedNov 13, 2015
@CBas My flex box currently expands to fill the viewport, but the individual tiles unfortunately change their height depending on the text content. How do I get them to expand to fill the screen, but still keep a consistent height no matter their text content?
@yongjun21 Please integrate Snake and Ping Pong into my game thanks.