Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging Feature branch with Master branch #4

Merged
merged 4 commits into from Nov 16, 2015
Merged

Conversation

tongrhj
Copy link
Owner

@tongrhj tongrhj commented Nov 13, 2015

@CBas My flex box currently expands to fill the viewport, but the individual tiles unfortunately change their height depending on the text content. How do I get them to expand to fill the screen, but still keep a consistent height no matter their text content?

@yongjun21 Please integrate Snake and Ping Pong into my game thanks.

@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 November 13, 2015 02:40 Active
@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 November 13, 2015 07:03 Active
display:flex;
flex-direction: row;
flex: 1;
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set them all to an equal height to override scaling based on content height.

flex-basis: 0;

@sebdeckers
Copy link

Looks nice and clean 👍

@tongrhj tongrhj deployed to tictactoe-reborn-pr-4 November 16, 2015 01:51 Active
@tongrhj tongrhj merged commit 6488d87 into master Nov 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants