Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename lambda #232

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@ceritium
Copy link
Contributor

commented Apr 14, 2019

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this) (

Summary

Rename Jets::AwsServices#lambda to Jets::AwsServices#aws_lambda.

Context

The method Jets::AwsServices#lambda collides with Kernel#lamba.

https://community.rubyonjets.com/t/collision-of-lambda-method/132

Do not merge it yet

@tongueroo tongueroo added the wip label Apr 14, 2019

@ceritium

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@tongueroo Some specs are failing on my local branch on master and on this branch too of course.

Fails on master

Finished in 4.05 seconds (files took 4.87 seconds to load)
388 examples, 12 failures

Failed examples:

rspec ./spec/lib/jets/controller/base_spec.rb:142 # Jets::Controller::Base posts index new adapter
rspec ./spec/lib/jets/controller/middleware/main_spec.rb:15 # Jets::Controller::Middleware::Main posts index call
rspec ./spec/lib/jets/controller/rack/adapter_spec.rb:8 # Jets::Controller::Rack::Adapter general convert
rspec ./spec/lib/jets/generate_spec.rb:3 # jets generate migration creates a migration file
rspec ./spec/lib/jets/middleware/configurator_spec.rb:30 # Jets::Middleware::Configurator configurator call
rspec ./spec/lib/jets/middleware_spec.rb:17 # Jets::Middleware middleware call
rspec ./spec/lib/jets/processors/main_processor_spec.rb:14 # Jets::Processors::MainProcessor controller create returns data
rspec ./spec/lib/shell_spec.rb:12 # Jets::CLI jets build
rspec ./spec/lib/shell_spec.rb:18 # Jets::CLI jets deploy
rspec ./spec/lib/shell_spec.rb:24 # Jets::CLI jets delete
rspec ./spec/lib/shell_spec.rb:30 # Jets::CLI jets routes
rspec ./spec/lib/shell_spec.rb:37 # Jets::CLI jets call

Apart from that, would you add something to the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.