Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont add /dev prefix if on_cloud9 #256

Merged
merged 1 commit into from May 23, 2019

Conversation

Projects
None yet
1 participant
@tongueroo
Copy link
Owner

commented May 23, 2019

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Fixes bug when the /dev is added to urls to view helpers when hitting the cloud9 url. This is reproducible when running:

jets server --port 8080 

And hitting the jets app with the cloud9 url and viewing the HTML source.

Good:

url-good

Bad:

url-bad

Context

https://community.rubyonjets.com/t/local-jets-server-causes-404-in-cloud9-because-of-dev-path-prefix/150/10

Version Changes

@tongueroo tongueroo merged commit 1754b85 into master May 23, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tongueroo tongueroo deleted the fix-local-dev-prefix branch May 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.