Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow adjustment for preheat job iam policy #290

Merged
merged 1 commit into from Jun 8, 2019

Conversation

Projects
None yet
1 participant
@tongueroo
Copy link
Owner

commented Jun 8, 2019

This is a 🙋‍♂️ feature or enhancement.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Brought up in Jets community: WarmLambdaFunction, TorchLambdaFunction dose not use my configured role

This allows users to adjust the generated IAM policy associated with the Jets::PreheatJob that handles Prewarming

Context

https://community.rubyonjets.com/t/warmlambdafunction-torchlambdafunction-dose-not-use-my-configured-role/188

Version Changes

@tongueroo tongueroo merged commit b9f5bc1 into master Jun 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tongueroo tongueroo deleted the prewarm-iam branch Jun 8, 2019

tongueroo added a commit that referenced this pull request Jun 10, 2019

Revert "Merge pull request #290 from tongueroo/prewarm-iam"
This reverts commit b9f5bc1, reversing
changes made to a210c58.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.