Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call long function names #301

Merged
merged 5 commits into from Jul 3, 2019

Conversation

@tongueroo
Copy link
Owner

commented Jul 3, 2019

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Whenever function names longer than the 64 char limit, Jets detects this and elects to have CloudFormation to generate the function names instead. This was done here: #160

Fixed the jets call method so it is aware of longer function names. Here's a test:

$ jets call admin-books_controller-very_long_method_name_that_is_over_the_limit_for_pretty_function_names | jq '.statusCode'
Calling lambda function demo-dev-AdminBooksContro-VeryLongMethodNameThatIs-1PWH67DBFV89T on AWS
Function name: demo-dev-AdminBooksContro-VeryLongMethodNameThatIs-1PWH67DBFV89T
"200"
$

Context

Related: https://community.rubyonjets.com/t/prewarm-function-guesses-errors/206

Version Changes

@tongueroo tongueroo merged commit dfe0149 into master Jul 3, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tongueroo tongueroo deleted the call-long-function-names branch Jul 3, 2019

@tongueroo

This comment has been minimized.

Copy link
Owner Author

commented Jul 8, 2019

Released in v1.9.28

@genail genail referenced this pull request Jul 9, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.