Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve jets call guesser, do a simple detection at the start #302

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@tongueroo
Copy link
Owner

commented Jul 8, 2019

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Improve the jets call guesser. At the very start, assume that the right underscored and dashed function name is passed and look up class based on that.

This fixes prewarming issues.

Note, could had also pass the guess: false option also to the Jets::Call class but the guesser logic has some nice logic that handles longer function names #301 Instead just going to make the guesser better.

Context

https://community.rubyonjets.com/t/prewarm-function-guesses-errors/206/5

Version Changes

@tongueroo tongueroo merged commit cdd18a3 into master Jul 8, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tongueroo tongueroo deleted the jets-call-guesser branch Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.