Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow url paths that contain dashes #305

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@tongueroo
Copy link
Owner

commented Jul 16, 2019

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Fix this route:

config/routes.rb:

Jets.application.routes.draw do
  get "url-with-dash", to: "posts#index"
end

Context

https://community.rubyonjets.com/t/deployment-failing-when-there-is-a-dash-in-a-route-name/211/2

Version Changes

@tongueroo tongueroo merged commit 3965f94 into master Jul 16, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tongueroo tongueroo deleted the dash-url branch Jul 16, 2019

@tongueroo

This comment has been minimized.

Copy link
Owner Author

commented Jul 16, 2019

Released in v1.9.30

it "contains info for CloudFormation API Gateway Resources" do
expect(resource.logical_id).to eq "UrlWithDashApiResource"
properties = resource.properties
pp properties

This comment has been minimized.

Copy link
@khalilovcmd

khalilovcmd Jul 17, 2019

Is this left over by accident?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.