Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix remove Rails const #330

Merged
merged 3 commits into from Aug 4, 2019

Conversation

@tongueroo
Copy link
Owner

commented Aug 4, 2019

  • also improve jets generate scaffold help menu to not require -h flag

This is a 馃悶 bug fix.

  • I've added tests (if it's a bug, feature or enhancement)
  • I've adjusted the documentation (if it's a feature or enhancement)
  • The test suite passes (run bundle exec rspec to verify this)

Summary

Rails const was accidentally reintroduced in v2. This removes it again.

Context

https://community.rubyonjets.com/t/why-does-jets-define-rails-module/29/6

Version Changes

tongueroo added some commits Aug 4, 2019

fix remove Rails const
* also improve `jets generate scaffold` help menu to not require `-h` flag

@tongueroo tongueroo merged commit 82d4d12 into master Aug 4, 2019

1 check was pending

ci/circleci CircleCI is running your tests
Details
@tongueroo

This comment has been minimized.

Copy link
Owner Author

commented Aug 4, 2019

Released in v2.0.3

@tongueroo tongueroo deleted the remove-rails-const branch Aug 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can鈥檛 perform that action at this time.