Skip to content

Usage with nav controller and tab bar? #11

Closed
alexcoplan opened this Issue Sep 7, 2012 · 4 comments

2 participants

@alexcoplan

Hi there,

What would you suggest for usage with a tab bar and a nav controller - will we need to create a new mode? At the moment I'm using the default (navigation mode?) and it works well, except that the action sheet is not shown from the tab bar, but the bottom of the screen and so the cancel button can't be selected.

My first idea was to not create a new mode, but add a config option called "useTabBar" (or similar), and that would simply tell it to present the actionsheet from the tab bar, whilst maintaining the current mode behaviour (e.g. navigation).

Alternatively, we could create a new mode TSMiniWebBrowserModeNavigationTabBar or something..

What do you think?

@alexcoplan

Fixed in my latest commit here.

@alexcoplan alexcoplan closed this Sep 7, 2012
@tonisalae
Owner

This issue with the tabbar makes the app crash in my tests. Did you tested it on various devices and iOS versions?

@tonisalae tonisalae reopened this Sep 22, 2012
@tonisalae
Owner

I have changed this condition:

else if (mode == TSMiniWebBrowserModeNavigation && [self.navigationController respondsToSelector:@selector(tabBarController)])

to this:

else if (mode == TSMiniWebBrowserModeNavigation && self.navigationController.tabBarController != nil)

This appears to work just fine in my tests. Does it make sense for you?

@alexcoplan

Yep that makes sense - thank you.

@alexcoplan alexcoplan closed this Sep 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.