Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Italic variant out of a custom version of Fira Mono #513

Open
brainplot opened this issue Oct 22, 2017 · 29 comments
Open

Italic variant out of a custom version of Fira Mono #513

brainplot opened this issue Oct 22, 2017 · 29 comments

Comments

@brainplot
Copy link

brainplot commented Oct 22, 2017

I know that this isn't from the original Fira Mono repository but this guy did a rather good job making a custom italic variant of Fira Mono.

https://github.com/zwaldowski/Fira/tree/zwaldowski/mod-new/otf

I've downloaded Fira Mono Italic and tweaked its name to "Fira Code" via FontForge so that it appears as the real italic variant of Fira Code in my font manager.
By doing this, my text editors use the custom version every time they need to use the italic variant (such as in comments or static methods/fields). This is the result:

fira-italic

To me it looks way better than all the editors trying to fake it. The problem is that there are no ligatures (as shown in the picture) because it's Fira Mono, obviously.
What do you think about creating Fira Code Italic out of that?
Hopefully an original Fira Mono Italic will come out, eventually, but in the meanwhile this might be an acceptable alternative.

@sohnryang
Copy link

Well, I think it'd be good if @tonsky adds ligatures on the custom Fira Mono Italic font.

@brainplot
Copy link
Author

Well, I think it'd be good if @tonsky adds ligatures on the custom Fira Mono Italic font.

Yeah, I stopped using this font because of this basically: the italic variant was just too ugly to look at.
Unfortunately, looks like this is not on his roadmap since this issue has been open for quite some time without receiving any replies; but that's fine. Mine was nothing more than a suggestion.

@tonsky
Copy link
Owner

tonsky commented Dec 25, 2018

I’m not against it, but it’s a lot of work. Basically re-creating each ligature in italics. Maybe one day...

@sohnryang
Copy link

Huh? carbon.now.sh supports Italic variant of Fira Code.

@sohnryang
Copy link

carbon

@j-f1
Copy link
Contributor

j-f1 commented Jan 2, 2019

That’s just a skewed version of the font.

@brainplot
Copy link
Author

brainplot commented Jan 2, 2019

I second what @j-f1 says.

@sohnryang, if the word log was italic, in your example, you would see how ugly it looks. It becomes immediately evident that the font doesn't have its own italic variant and the editor tries its best to make it look like it does (and the result is not consistent across all editors, probably that's one reason why it looks really ugly). It's even more evident when you compare it with a font that does have an italic variant.

@Avi-D-coder
Copy link

I made a corrected auto italic version FiraCode-italic. There are a few things left to fix, but it is very usable.

@j-f1
Copy link
Contributor

j-f1 commented Sep 26, 2019

@Avi-D-coder Awesome! My one suggestion would be to take inspiration from Fira Sans for some of the lowercase letters, which have different forms in italic:

Fira Sans regular and italic lowercase letters

Same as above, but with differences highlighted

All the other letters are identical for roman/italic forms in Fira Sans.

@Avi-D-coder
Copy link

@j-f1 I'll look into fixing it, soonish.

@Avi-D-coder
Copy link

Avi-D-coder commented Sep 27, 2019

There are more character differences, I am going to scale all the sans italics to make them mono spaced rather than patching the italicized mono. It will look better, but its going to take some time.

Edit on second look Fira Mono and Fira sans are significantly different. Fira Mono includes many serif like touches.

@Avi-D-coder
Copy link

@j-f1 Take a look, I changed the requested characters

@j-f1
Copy link
Contributor

j-f1 commented Sep 28, 2019

I love it! A few things:

  • the line height seems to be different from the regular Fira Code (in this case, the variable font version)
  • the r is missing its serif
  • stylistic sets (i.e. for $) don’t seem to be supported

Did you do the initial conversion from Fira Code v2 or an older version?

Screen Shot 2019-09-28 at 15 02 03

@Avi-D-coder
Copy link

@j-f1 I presently don't support style sheets. To quote the readme "This is my manually corrected and auto Ligaturized, version of @zwaldowski's synthesized italic version of Mozilla's Fira Mono."

If you want to add style sheets, I would gladly except a PR. The font source is in Avi-D-coder/fira-mono-italic. Once there is a mono-italic version with style sheets, you or I could run it through Ligaturizer.

@scott-ln
Copy link

scott-ln commented Oct 8, 2019

@Avi-D-coder Thanks a lot for this! However I just installed it on Windows and text that was previously italicized in my editor (Sublime Text) has now stopped being in italics. Do you know if there's something else that I need to do?

@Avi-D-coder
Copy link

@scott-ln I don't have Windows so it has not been tested with it. In Linux installing the files from the repo is enough

@scott-ln
Copy link

scott-ln commented Oct 8, 2019

No worries, thank you. I wonder if @tonsky may know why having compiled a support table for Fira Code in various editors.

@tonsky
Copy link
Owner

tonsky commented Oct 8, 2019

I have no idea. Wrong name for italics variant?

@Avi-D-coder
Copy link

@scott-ln could you screen shot your font manager

@scott-ln
Copy link

scott-ln commented Oct 8, 2019

The italic variants are picked up in Windows settings:

Fira Code in settings

However I can see that if you open the font files by double-clicking to preview them (the pre-Windows 10 way), "Font name" appears only as "Fira Code", so that may well be the issue. Opening other members of the family this way shows "Fira Code Light", etc.

Fira Code RegularItalic open

Fira Code BoldItalic open

@Avi-D-coder
Copy link

Are you using the most recent version from my repo?

@scott-ln
Copy link

scott-ln commented Oct 8, 2019

Yes, from fira-mono-italic/distr/otf/.

@scott-ln
Copy link

Very happy to report that after a system update that involved a restart, the issue has gone away. Just Windows being Windows, I guess. Thanks again for your work Avi!

@scott-ln
Copy link

Hi, sorry, me again. Now that the italic characters are visible, it appears that their baseline is lower than the other variants.

image

@tomasdev
Copy link

tomasdev commented Mar 3, 2020

Are there plans to make italic become part of FiraCode officially?

@tonsky
Copy link
Owner

tonsky commented Mar 4, 2020

Are there plans to make italic become part of FiraCode officially?

Not unless they are added to Fira Mono

@brainplot
Copy link
Author

Not unless they are added to Fira Mono

Sadly I don't see this happening, ever. I've looked at the repo and it doesn't seem to be actively developed.

@tonsky
Copy link
Owner

tonsky commented Mar 4, 2020

Mozilla repo is dead, developers tried to revive it under a new name at https://github.com/bBoxType/FiraGO. Not too many updates, most probably because the work is not funded, but who knows?

@TBBle
Copy link

TBBle commented Sep 21, 2020

FiraGO still has the entirety of 'Mono' as a TODO, and nothing's shifted in that respect since 2018, when they said explicitly that they weren't funded for that in bBoxType/FiraGO#16 (comment).

Perhaps for italic, they would take a contribution from, e.g., https://github.com/Avi-D-coder/fira-mono-italic, itself based on https://github.com/zwaldowski/Fira/tree/zwaldowski/mod-new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants