Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better feedback when mixing argvec/mixin order #88

Closed
martinklepsch opened this issue Jul 24, 2016 · 1 comment
Closed

Better feedback when mixing argvec/mixin order #88

martinklepsch opened this issue Jul 24, 2016 · 1 comment

Comments

@martinklepsch
Copy link
Contributor

martinklepsch commented Jul 24, 2016

It has happened to me a few times now that I got stuck because I put the mixin in the wrong place.

(defc x
  [a b]
  < rum/static
  [:div "bla"])

I think this is something that could be improved to give better feedback.
While throwing an exception isn't guaranteed to be correct the probability of false positives seems low (i.e. component bodies starting with a plain <).

Would you be interested in a patch that throws for the above snippet? Do you have alternative suggestions that might be less absolute?

Maybe throwing an exception is a good first step and can be revisited once there is some user feedback.

@tonsky
Copy link
Owner

tonsky commented Jul 25, 2016

I think it’s a good idea, yes

On Mon, Jul 25, 2016 at 4:35 AM Martin Klepsch notifications@github.com
wrote:

It has happened to me a few times now that I'm stuck because I put the
mixin in the wrong place.

(defc x
[a b]
< rum/static
[:div "bla"])

I think this is something that could be improved to give better feedback.
While throwing an exception isn't guaranteed to be correct the probability
of false positives seems low (i.e. component bodies starting with a plain
<).

Would you be interested in a patch that throws for the above snippet? Do
you have alternative suggestions that might be less absolute?

Maybe throwing an exception is a good first step and can be revisited once
there is some user feedback.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#88, or mute the thread
https://github.com/notifications/unsubscribe-auth/AARabA3VHXplbUsX3yimr0tVZQZ-rMD8ks5qY9qigaJpZM4JTrLf
.

martinklepsch added a commit to martinklepsch/rum that referenced this issue Jul 25, 2016
@tonsky tonsky closed this as completed in df3d300 Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants