Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TonY uses both tony.history.location and tony.historyFolder #96

Closed
erwa opened this issue Nov 20, 2018 · 2 comments
Closed

TonY uses both tony.history.location and tony.historyFolder #96

erwa opened this issue Nov 20, 2018 · 2 comments
Assignees

Comments

@erwa
Copy link
Contributor

erwa commented Nov 20, 2018

Currently, tony-default.xml contains tony.history.location whereas other places use tony.historyFolder. We should standardize on one. Looking at Hadoop configs, seems like all.lowercase.period.separated is the more standard naming convention, rather than using camelCase in config names.

We should also avoid hardcoding tony.historyFolder in multiple places and instead define a String constant once and use that elsewhere.

@erwa
Copy link
Contributor Author

erwa commented Nov 20, 2018

Note that TONY_HISTORY_LOCATION is already defined in TonyConfigurationKeys.java.

@pdtran3k6
Copy link
Contributor

Note that TONY_HISTORY_LOCATION is already defined in TonyConfigurationKeys.java.

For TonyClient, retrieving this value is easy. However, for tony-history-server, although I know that there's prolly a way to import TonyConfigurationKeys.java and use it within the controllers code, I don't know how, so I'm going to work on #97 first, and hardcode the key (tony.history.location + default value) for now (at least inside tony history server code).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants