Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react: @carbon/charts #1154

Merged
merged 4 commits into from
Jan 19, 2021
Merged

react: @carbon/charts #1154

merged 4 commits into from
Jan 19, 2021

Conversation

tony
Copy link
Owner

@tony tony commented Jan 2, 2021 •
edited

Staging URL: https://cv-react-v2.git-pull.com/dev/branch/v2-carboncharts/

Thanks #1150

https://github.com/carbon-design-system/carbon-charts

image

good stuff:

  • typescript, out of the box
  • framework adapters for react, angular, vue, maintained by the core team
  • the team is nice and attentive
  • animations work out of the box

issues:

my existential issues:

  • Donut isn't filled after data updates
  • requires the carbon components base package. For a chart system.
  • the core of carbon components isn't TypeScript. And it's huge, and may never be TS
  • Bundle Size: Package performance and bundle-size carbon-design-system/carbon#4882
  • Haven't tried it yet for angular or vue, and already spent 3 days between this and the other 2 libraries

@tony tony mentioned this pull request Jan 2, 2021
Closed
@tony tony force-pushed the v2 branch 3 times, most recently from 5f3bd11 to 8b23c80 Compare January 2, 2021 15:18
@tony tony force-pushed the v2-carboncharts branch 2 times, most recently from e35b122 to eefc5b5 Compare January 2, 2021 18:54
@tony tony force-pushed the v2-carboncharts branch 3 times, most recently from ba64442 to 6f413a2 Compare January 2, 2021 19:27
@tony tony changed the base branch from v2 to master January 2, 2021 19:41
@tony tony force-pushed the v2-carboncharts branch 3 times, most recently from b760291 to b26fe5c Compare January 2, 2021 20:05
@tony tony mentioned this pull request Jan 3, 2021
Open
@tony tony force-pushed the v2-carboncharts branch 5 times, most recently from 1b42465 to 32e5923 Compare January 3, 2021 05:07
@tony tony mentioned this pull request Jan 3, 2021
Closed
@tony tony force-pushed the v2-carboncharts branch 3 times, most recently from acdff6d to 8e1668d Compare January 3, 2021 14:24
@tony tony force-pushed the v2-carboncharts branch 3 times, most recently from 3c18397 to 67b0cee Compare January 3, 2021 16:10
@tony tony force-pushed the v2-carboncharts branch 7 times, most recently from 2e9bab3 to caf9e67 Compare January 9, 2021 19:09
@tony tony force-pushed the v2-carboncharts branch 2 times, most recently from f92b0e4 to 6315ddf Compare January 10, 2021 01:54
@tony tony force-pushed the v2-carboncharts branch 6 times, most recently from 2285b2f to 34d0ad3 Compare January 16, 2021 17:46
@tony tony force-pushed the v2-carboncharts branch 4 times, most recently from 5b71a70 to 0fa4867 Compare January 18, 2021 03:13
@tony
Add charts via @carbon/charts
f2cc06e 
Snags:
- react/chart: Disable legend for now (keep the DonutChart) 🍩
- react/donut chart: Remove data.selectedGroups props (fixes chart updates)

  There's something at issue with selectedGroups clearing / pruning
  results when sets are passed.

  Even when the legend was removed, having any interaction passing props
  to data.selectedGroups kept stale values.

!squash
@tony
react/plotly: Fix declaration import
6039b1c
@tony tony force-pushed the v2-carboncharts branch 2 times, most recently from 164fcbf to 6039b1c Compare January 19, 2021 14:24
@tony tony merged commit b4830c4 into master Jan 19, 2021
@tony tony deleted the v2-carboncharts branch January 19, 2021 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📈 Charts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tony