-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react: @carbon/charts #1154
Merged
Merged
react: @carbon/charts #1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5f3bd11
to
8b23c80
Compare
e35b122
to
eefc5b5
Compare
ba64442
to
6f413a2
Compare
b760291
to
b26fe5c
Compare
1b42465
to
32e5923
Compare
acdff6d
to
8e1668d
Compare
3c18397
to
67b0cee
Compare
2e9bab3
to
caf9e67
Compare
f92b0e4
to
6315ddf
Compare
2285b2f
to
34d0ad3
Compare
5b71a70
to
0fa4867
Compare
Snags: - react/chart: Disable legend for now (keep the DonutChart) 🍩 - react/donut chart: Remove data.selectedGroups props (fixes chart updates) There's something at issue with selectedGroups clearing / pruning results when sets are passed. Even when the legend was removed, having any interaction passing props to data.selectedGroups kept stale values. !squash
164fcbf
to
6039b1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staging URL: https://cv-react-v2.git-pull.com/dev/branch/v2-carboncharts/
Thanks #1150
https://github.com/carbon-design-system/carbon-charts
good stuff:
issues:
my existential issues: