New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tmux freeze fails #239
Comments
To add, I was able to do |
Can you try to recreate the settings and return the results of |
I did not follow that. Also, I am using tmux version 2.4+ (built from its master branch).
|
Just meant if you could recreate the error, while pulling the info from those commands. It helps me try to figure out what could be causing the glitch. I'm very interested in the output of |
No problem.. Here are the results for main:1: scratch (4 panes) [283x63]
main:2: tok1#- (4 panes) [283x63]
main:3: tok2* (4 panes) [283x63]
main:4: tok_cosim (3 panes) [283x63]
main:5: tok-regr (3 panes) [283x62]
main:6: dummy (3 panes) [283x62]
main:7: uvm_lib (1 panes) [283x62]
main:8: sandbox (3 panes) [283x62]
main:9: hugo (2 panes) [283x63]
|
Now I toggled pane synchronization in all windows. Now all windows show:
But |
I wonder if this were to still happen in 2.4 built from the release changeset. I think that the I'm wondering what your tmux configuration looks like. Are you using tmuxp configs as well? |
Could you try to put a |
My pane border setup:
No, I haven't configured tmuxp in any way, using it as default. |
Your suspicion was correct!
So looks like tmuxp needs to allow spaces in |
Interested in trying a PR? It's something that could be done via the tests. Or I could give it a go. |
I wish I could help. While I can understand Python scripts with help from google, SO, etc, I don't think I can tackle this.. But still let me give it a try. I can now run
|
While I can try fixing this, not sure if I can write tests for that :) |
You're welcome to try a suggestion and post it here, but it's not helpful without a regression test. It should be relatively easy to add. https://github.com/tony/tmuxp/blob/6eabe5e6e5c177197788761eeff737b747e70a7e/tests/test_workspacebuilder.py#L238 Adding a
It may only require editing Seem like too much work? Need time? What do you think? |
This fixes stuff from my quick testing:
Any objections to adding this new dependency? |
Looks like an idea, why not try making a PR to libtmux. I'll add a test on both ends. An aside: No need to reference SO for something simple as that, by the way. tmuxp is BSD licensed and we don't want to appear like we're taking viral CC SA (share alike) code. No need to comment the import, but you can add move that comment to the line above |
Fixes tmux-python/tmuxp#239 With the below in tmux config: setw -g pane-border-format " #P " Before the fix: ('pane-border-format', '"', '#P', '"') After the fix: ('pane-border-format', ' #P ')
Done! ( tmux-python/libtmux#37 )
Yes, can you please do that this time.. I will observe and learn how you updated the tests.
The PR has your suggestions applied. Thanks! |
Oh well, looks like things are failing. I'll get some time at later to understand how the |
Take your time. If you need to take a different approach, that's fine too. |
Another thing about
|
This means that 2.6 support would have to be dropped. In libtmux, and therefore tmuxp, too. 2.6 was asked about back in 2013 @ #13. I'm willing to weigh dropping 2.6 support if you can't find an approach. |
Yes, I was reading
has to do with Unicode support.
Thanks for the consideration. I wouldn't rely on my ability to find a different approach as I am not a serious Python coder. I can even keep on using my forked version with the fix. |
I am going to consider loosening the 2.6 requirement. It's been almost 4 years since that issue. Last 2.6 release was 2.6.9 in October 29, 2013. Support ended then. |
Fixes tmux-python/tmuxp#239 With the below in tmux config: setw -g pane-border-format " #P " Before the fix: ('pane-border-format', '"', '#P', '"') After the fix: ('pane-border-format', ' #P ')
This is live in 1.3.0 |
Hi,
I just installed tmuxp using
pip3 install tmuxp
. It believed it installed fine because if I type justtmuxp
, it shows the help.I have a tmux session named
main
. But when I typedtmuxp freeze main
, I got this backtrace:Python version: 3.6.1
OS: RHEL 6.6
The text was updated successfully, but these errors were encountered: