Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inconsistency between getsamples() and i_img_bits_t names #488

Open
tonycoz opened this issue May 18, 2022 · 0 comments
Open

inconsistency between getsamples() and i_img_bits_t names #488

tonycoz opened this issue May 18, 2022 · 0 comments

Comments

@tonycoz
Copy link
Owner

tonycoz commented May 18, 2022

getsamples()/setsamples() accepts a type value of "float", which was reasonable at the time, but the new data() method will distinguish between returning "float" data (as packed C floats) and "double" data (as packed C doubles).

This inconsistency at the very least complicates testing, but it also makes learning the interfaces harder.

While getsamples() etc won't support packed C floats soon, it may in the future, so keeping them consistent would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant