Update EClientScriptBoost.php #21

Merged
merged 4 commits into from Apr 8, 2014

Projects

None yet

2 participants

@mdeweerd

Caching some scripts results in 'clashes' with caching accross users, for example when CRSF is used.
When this is inside the application, this can be fixed, but before fixing, the issue must be identified.
When this is inside the framework, fixing is "not possible".

My changes allow the developer to identify the caching issues with the script when YII_DEBUG is set. The caching is done 'as usual' but the script is compressed every time in debug mode and compared with the cached version. In case there is a difference, this is reported.

Further, 'CButtonColumn' registers JavaScript including the 'delete' button function which uses CSRF when enabled. Therefore, it can not be cached as the key only depends on the grid id and not on the CSRF.

mdeweerd added some commits Dec 24, 2013
@mdeweerd mdeweerd Update EClientScriptBoost.php
Caching some scripts results in 'clashes' with caching accross users, for example when CRSF is used.
When this is inside the application, this can be fixed, but before fixing, the issue must be identified.
When this is inside the framework, fixing is "not possible".

My changes allow the developer to identify the caching issues with the script when YII_DEBUG is set.  The caching is done 'as usual' but the script is compressed every time in debug mode and compared with the cached version.  In case there is a difference, this is reported.

Further, 'CButtonColumn' registers JavaScript including the 'delete' button function which uses CSRF when enabled.  Therefore, it can not be cached as the key only depends on the grid id and not on the CSRF.
3a3a89a
@mdeweerd mdeweerd Update EClientScriptBoost.php
CJuiDialog is also an issue, and fixed bug in code to skip these classes.
c5b7135
@mdeweerd mdeweerd Update EClientScriptBoost.php
Discovered a few other core classes giving trouble with the registered scripts -> added exceptions.
3b7ffd0
@mdeweerd mdeweerd Update EClientScriptBoost.php
Added Editable Field and JToggleColumn (stuff in extensions).
c549d85
@tonydspaniard

Great work... Thanks

@tonydspaniard tonydspaniard merged commit ea0f08d into tonydspaniard:master Apr 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment