Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPX library #1

Open
tonymorris opened this issue Oct 16, 2013 · 3 comments
Open

Update GPX library #1

tonymorris opened this issue Oct 16, 2013 · 3 comments
Assignees

Comments

@tonymorris
Copy link
Owner

@tonymorris tonymorris commented Oct 16, 2013

I am considering updating this library. In particular;

  • Use Control.Lens instead of Data.Lens
  • Implement zipper
  • Implement tests against GPX files
  • Implement tests using doctest
  • Read whitespace in GPX file so as to recover the original file.
  • Rename the package from GPX to gpx (what is the procedure for this?)
  • Provide higher-level functions for easy manipulation of gpx files.
  • Use Data.Text instead of String
  • Use explicit imports and NoImplicitPrelude (code style)
  • User a proper coordinate data type

Just wondering if there might be any other interest or comment.

@TomMD

@ghost ghost assigned tonymorris Oct 16, 2013
@ocharles
Copy link

@ocharles ocharles commented Nov 24, 2015

I would be interested in helping out with some of this, as I have a need to use this package. Specifically, I would be willing to:

  • Use Control.Lens
  • Use Data.Text

I'm wondering about exposing the constructors more, too. I also think the package would be a lot easier to navigate if there were less modules.

@tonymorris
Copy link
Owner Author

@tonymorris tonymorris commented Nov 24, 2015

Yeah I agree with exposing the constructors where appropriate (i.e. hiding is not to enforce some sort of invariant).

@TomMD
Copy link
Collaborator

@TomMD TomMD commented Nov 24, 2015

@tonymorris I appreciate the ping on this, but I don't have the bandwidth to contribute at this time.

Edit: Just noticed the ping was years ago... oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants