Skip to content
Permalink
Branch: jit-interface-…
Commits on Jan 10, 2017
  1. Can't find any correct docs on DWARF registers

    tonysimpson committed Jan 10, 2017
    Using GDB register numbers which are properly documented and simple.
Commits on Feb 9, 2016
  1. Fix JIT Interface

    tonysimpson committed Feb 9, 2016
    Fixes:
      * Named blocks not appearing as functions - can't break on functions;
      * Pending breakpoints on JIT'd code not being resolved;
      * GDB goes into an infinit loop with more than one JIT block in a
         symtab;
      * Unwinder function not being called.
Commits on Feb 8, 2016
  1. Always organize test artifacts in a directory hierarchy

    Simon Marchi
    Simon Marchi committed Feb 8, 2016
    When running tests in parallel, each test puts its generated files in a
    different directory, under "outputs".  I think it would be nice if it
    was always the case, as it would isolate the test cases a bit more.  An
    artifact created by a test wouldn't get overwritten by another test.
    
    Also, it makes it easier to clean up.  A lot of executables are left all
    over the place because their names do not appear in gdb.*/Makefile.  If
    everything is in "outputs", then we just have to delete that directory
    (which we already do).
    
    At the same time it makes the gdb.foo directories and their Makefiles
    useless in the build directory, since they are pretty much only used for
    cleaning.
    
    What do you think?
    
    gdb/testsuite/ChangeLog:
    
    	* Makefile.in (ALL_SUBDIRS): Remove.
    	(clean mostlyclean): Do not recurse in ALL_SUBDIRS.
    	(distclean maintainer-clean realclean): Likewise.
    	* configure.ac (AC_OUTPUT): Remove gdb.*/Makefile.
    	* configure: Regenerate.
    	* gdb.ada/Makefile.in: Delete.
    	* gdb.arch/Makefile.in: Likewise.
    	* gdb.asm/Makefile.in: Likewise.
    	* gdb.base/Makefile.in: Likewise.
    	* gdb.btrace/Makefile.in: Likewise.
    	* gdb.cell/Makefile.in: Likewise.
    	* gdb.compile/Makefile.in: Likewise.
    	* gdb.cp/Makefile.in: Likewise.
    	* gdb.disasm/Makefile.in: Likewise.
    	* gdb.dlang/Makefile.in: Likewise.
    	* gdb.dwarf2/Makefile.in: Likewise.
    	* gdb.fortran/Makefile.in: Likewise.
    	* gdb.gdb/Makefile.in: Likewise.
    	* gdb.go/Makefile.in: Likewise.
    	* gdb.guile/Makefile.in: Likewise.
    	* gdb.java/Makefile.in: Likewise.
    	* gdb.linespec/Makefile.in: Likewise.
    	* gdb.mi/Makefile.in: Likewise.
    	* gdb.modula2/Makefile.in: Likewise.
    	* gdb.multi/Makefile.in: Likewise.
    	* gdb.objc/Makefile.in: Likewise.
    	* gdb.opencl/Makefile.in: Likewise.
    	* gdb.opt/Makefile.in: Likewise.
    	* gdb.pascal/Makefile.in: Likewise.
    	* gdb.perf/Makefile.in: Likewise.
    	* gdb.python/Makefile.in: Likewise.
    	* gdb.reverse/Makefile.in: Likewise.
    	* gdb.server/Makefile.in: Likewise.
    	* gdb.stabs/Makefile.in: Likewise.
    	* gdb.threads/Makefile.in: Likewise.
    	* gdb.trace/Makefile.in: Likewise.
    	* gdb.xml/Makefile.in: Likewise.
    	* lib/gdb.exp (make_gdb_parallel_path): Add check for
    	GDB_PARALLEL.
    	(standard_output_file): Remove check for GDB_PARALLEL, always
    	return path in outputs/$subdir/$testname.
  2. Fix in-tree, parallel running of Ada tests

    Simon Marchi
    Simon Marchi committed Feb 8, 2016
    While testing the following patch,
    
      [PATCH] Always organize test artifacts in a directory hierarchy
      https://sourceware.org/ml/gdb-patches/2016-01/msg00133.html
    
    I noticed that it broke Ada testing.  This lead me to think that
    parallel testing when building in-tree didn't work previously in Ada.
    It is confirmed by this test:
    
    $ make check TESTS="gdb.ada/fun_addr.exp" -j 2
    ...
    Running ./gdb.ada/fun_addr.exp ...
    FAIL: gdb.ada/fun_addr.exp: compilation foo.adb
    ...
    
    This patch fixes in-tree parallel testing for Ada, and consequently
    serial and parallel testing when the aforementioned patch is applied.
    
    The problem originates from the fact that Ada support code cd's to the
    builddir before compiling.  In itself it's not a problem, it allows to
    place intermediate auto-generated files in that directory.  The Ada
    compilation refers to the source file, which is in another directory,
    only by its base name (e.g. foo.adb).  In serial mode, that worked
    because builddir was the same as the source directory (e.g.
    gdb.ada/fun_addr/).  In an out-of-tree build, it works because the
    source directory is added as an include directory (note: this is not the
    same $srcdir as autoconf's):
    
      set srcdir [file dirname $source]
      additional_flags=-I$srcdir
    
    which becomes:
    
      additional_flags=-I/home/emaisin/build/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr
    
    However, when building in-tree, srcdir is relative: ./gdb.ada/fun_addr.
    When using parallel or always-in-outputs-directory mode, we are cd'ed in
    the outputs directory.  So -I$srcdir is relative to the current
    directory, which is wrong.
    
    To fix it, I made the TCL variable srcdir (set in site.exp, from which
    everything else is derived) always absolute.  It is done by assigning
    autoconf's abs_srcdir instead of autoconf's srcdir.  This way -I$srcdir
    will always be good, regardless of where we cd'ed to.  A small apparent
    change is that when running tests, DejaGnu will say:
    
      Running /tmp/binutils-gdb/gdb/testsuite/gdb.ada/fun_addr.exp ...
    
    instead of
    
      Running ./gdb.ada/fun_addr.exp ...
    
    I hope it's not too much of an annoyance.  I think that it should make
    the testsuite a tiny bit more robust against other bugs of the same
    class.
    
    Regtested in & out of tree, only with native target.
    
    gdb/testsuite/ChangeLog:
    
    	* Makefile.in (abs_srcdir): Assign @abs_srcdir@.
    	(site.exp): Assign abs_srcdir to tcl's srcdir.
  3. remote.c: Cleanup unused variables

    Simon Marchi
    Simon Marchi committed Feb 8, 2016
    I built remote.c with -Wunused, to check a function I was working on,
    turns out there is a bunch of unused variables.
    
    gdb/ChangeLog:
    
    	* remote.c (remote_register_number_and_offset): Remove unused
    	variable(s).
    	(remote_thread_always_alive): Likewise.
    	(remote_update_thread_list): Likewise.
    	(process_initial_stop_replies): Likewise.
    	(remote_start_remote): Likewise.
    	(remote_check_symbols): Likewise.
    	(discard_pending_stop_replies): Likewise.
    	(process_stop_reply): Likewise.
    	(putpkt_binary): Likewise.
    	(getpkt): Likewise.
    	(remote_add_target_side_condition): Likewise.
    	(remote_insert_breakpoint): Likewise.
    	(remote_supports_stopped_by_sw_breakpoint): Likewise.
    	(remote_supports_stopped_by_hw_breakpoint): Likewise.
    	(remote_xfer_partial): Likewise.
    	(remote_read_btrace): Likewise.
    	(remote_async_serial_handler): Likewise.
    	(remote_thread_events): Likewise.
    	(_initialize_remote): Likewise.
  4. FIx formatting that triggers a new compile time warning message.

    nickclifton committed Feb 8, 2016
    	* config/tc-ia64.c (dot_prologue): Fix formatting.
  5. Automatic date update in version.in

    GDB Administrator authored and brobecke committed Feb 8, 2016
Commits on Feb 7, 2016
  1. Add additional information to relocation overflow errors.

    ccoutant committed Feb 7, 2016
    gold/
    	PR gold/18695
    	* x86_64.cc (Target_x86_64::Relocate::relocate): Add additional
    	information to relocation overflow errors.
  2. Fix incorrect x32 overflow checking for refs to weak undef symbols.

    ccoutant committed Feb 7, 2016
    On x32, a pc-relative reference to an undef weak symbol (value 0)
    with a negative addend (typically -4) generates a spurious overflow
    error because Symbol_value::value() returns a 32-bit negative number
    as an unsigned number, which gets zero-extended before subtracting
    the PC value. This patch fixes the problem by special-casing the
    negative addend, and adding it to the value after widening it to
    64 bits. Symbol_value::value() does not need the addend if it's
    negative, since it is only important when processing section
    symbols for merge sections, where a positive addend provides the
    input section offset of the merged constant.
    
    gold/
    	* x86_64.cc (X86_64_relocate_functions::pcrela32_check): Fix x32
    	overflow checking when symbol value + addend < 0.
  3. varobj: Cleanup dead code

    simark committed Feb 7, 2016
    This patch removes some dead code.
    
    I noticed that varobj_delete was always called with dellist == NULL, so
    I started removing that parameter.  That allows removing a good chunk of
    the code in varobj_delete, making it almost trivial.  We can also remove
    the resultp parameters in that whole trail.  In turn, this shows that
    struct cpstack, cppush and cppop were only used fo that mechanism, so
    they can be removed as well.
    
    I also moved the function comment to the header file to comply with
    today's guideline, even though the rest of the file does not respect it
    (yet).
    
    gdb/ChangeLog:
    
    	* varobj.h (varobj_delete): Remove dellist parameter, update and
    	move documentation here.
    	* varobj.c (struct cpstack, cppush, cppop): Remove.
    	(delete_variable): Remove resultp (first) parameter.
    	(delete_variable_1): Likewise.
    	(varobj_delete): Remove dellist parameter and unused code.
    	(update_dynamic_varobj_children): Adjust varobj_delete call.
    	(update_type_if_necessary): Likewise.
    	(varobj_set_visualizer): Likewise.
    	(varobj_update): Likewise.
    	(value_of_root): Likewise.
    	(varobj_invalidate_iter): Likewise.
    	* mi/mi-cmd-var.c (mi_cmd_var_delete): Likewise.
  4. Fix compile errors about shift counts too large.

    ccoutant committed Feb 7, 2016
    In order to get around the optimizer and newer compiler warnings
    about shift counts, the overflow checking code had resorted to
    some messy shifting, and with the never-before-seen instantiations
    of the template functions, we were still running afoul of the
    compiler checks.
    
    This patch replaces those messy shift sequences with a simple
    class template that provides the min and max limits for any
    bit size up to 64, with a specialization for 64 that prevents
    the compiler from complaining.
    
    gold/
    	PR gold/19577
    	* reloc.h (Limits): New class.
    	(Bits::has_overflow32): Use min/max values from Limits.
    	(Bits::has_unsigned_overflow32): Likewise.
    	(Bits::has_signed_unsigned_overflow32): Likewise.
    	(Bits::has_overflow): Likewise.
    	(Bits::has_unsigned_overflow): Likewise.
    	(Bits::has_signed_unsigned_overflow64): Likewise.
  5. Automatic date update in version.in

    GDB Administrator authored and brobecke committed Feb 7, 2016
Commits on Feb 6, 2016
  1. Fix overflow checking for 32-bit pc-relative relocations on x32.

    ccoutant committed Feb 6, 2016
    The problem here is that x32 is really using 64-bit addressing,
    while pretending to be 32-bit. Even though the object file format
    is 32-bit, we need to do the overflow checking with 64-bit
    arithmetic (because that's what the hardware will be using).
    This patch overrides the pcrela32_check functions in reloc.h
    with target-specific versions that do 64-bit checking.
    
    I've also updated the test case to use -Tdata instead of adding
    a huge .space directive, to reduce the size of the .o files.
    
    gold/
    	PR gold/19567
    	* reloc.h (Relocate_functions::Overflow_check): Add comments.
    	* x86_64.cc (X86_64_relocate_functions): New class.
    	(Target_x86_64::Relocate::relocate): Use the new class.
    	* testsuite/Makefile.am (x86_64_overflow_pc32): Add -Tdata option.
    	(x32_overflow_pc32): New test case.
    	* testsuite/Makefile.in: Regenerate.
    	* testsuite/x32_overflow_pc32.sh: New script.
    	* testsuite/x86_64_overflow_pc32.s: Remove .space directive.
  2. Fix incorrect casts.

    ccoutant committed Feb 6, 2016
    gold/
    	PR gold/19577
    	* reloc.h (Bits::has_unsigned_overflow32): Fix static_cast.
    	(Bits::has_unsigned_overflow): Remove unnecessary static_cast.
  3. Fix build failure in gold due to signed vs. unsigned comparisons.

    ccoutant committed Feb 6, 2016
    	* reloc.h (Bits::has_unsigned_overflow32): Fix unsigned/signed
    	comparison.
    	(Bits::has_unsigned_overflow): Likewise.
  4. sim: mips: fix prog_bfd usage

    vapier committed Feb 6, 2016
    We do not want to reference the "base" member directly.  We have the
    STATE_PROG_BFD macro instead to look up the prog_bfd member.
  5. gold: Add view and view_size parameters to is_call_to_non_split.

    koriakin committed Feb 6, 2016
    This is needed by s390 split-stack support, to distinguish call
    and load-address relocations.
    
    gold/ChangeLog:
    
    	* i386.cc (Target_i386::is_call_to_non_split): Add view and view_size
    	parameters.
    	* reloc.cc (Sized_relobj_file::split_stack_adjust_reltype): Pass view
    	and view_size to is_call_to_non_split.
    	* target.cc (Target::is_call_to_non_split): Add view and view_size
    	parameters.
    	* target.h (class Target): Likewise.
  6. Automatic date update in version.in

    GDB Administrator authored and brobecke committed Feb 6, 2016
Commits on Feb 5, 2016
  1. 2016-02-05 Sriraman Tallam <tmsriram@google.com>

    tmsri committed Feb 5, 2016
    	* icf.cc (get_rel_addend): New function.
    	(get_section_contents):  Move merge section addend computation to a
    	new function.  Ignore negative values for SHT_REL and SHT_RELA addends.
    	Fix bug to not read past the length of the section.
    
    Fix bug related to addend computation for MERGE sections.
  2. Add some relocation overflow checks for x86_64.

    ccoutant committed Feb 5, 2016
    2016-02-05  Cary Coutant  <ccoutant@gmail.com>
    	    Andrew Senkevich  <andrew.senkevich@intel.com>
    
    gold/
    	PR gold/18695
    	* x86_64.cc (Target_x86_64::Relocate::relocate): Add overflow
    	checking for R_X86_64_32, R_X86_64_32S, R_X86_64_PC32, and
    	R_X86_64_PLT32.
    	* testsuite/Makefile.am (x86_64_overflow_pc32): New test.
    	* testsuite/x86_64_overflow_pc32.sh: New test script.
    	* testsuite/x86_64_overflow_pc32.s: New source file.
  3. Overhaul relocation framework to support overflow checking.

    ccoutant committed Feb 5, 2016
    gold/
    	PR gold/18695
    	* reloc.h (Relocate_functions::Address): New typedef.
    	(Relocate_functions::Addendtype): New typedef.
    	(Relocate_functions::Overflow_check): New enum type.
    	(Relocate_functions::Reloc_status): New enum type.
    	(Relocate_functions::check_overflow): New function template.
    	(Relocate_functions::rel): Add check parameter; check for overflow.
    	(Relocate_functions::rel_unaligned): Likewise.
    	(Relocate_functions::rela): Likewise.
    	(Relocate_functions::pcrel): Likewise.
    	(Relocate_functions::pcrel_unaligned): Likewise.
    	(Relocate_functions::pcrela): Likewise.
    	(Relocate_functions::rel8): Adjust parameter types.
    	(Relocate_functions::rela8): Likewise.
    	(Relocate_functions::pcrel8): Likewise.
    	(Relocate_functions::pcrela8): Likewise.
    	(Relocate_functions::rel16): Likewise.
    	(Relocate_functions::rela168): Likewise.
    	(Relocate_functions::pcrel16): Likewise.
    	(Relocate_functions::pcrela16): Likewise.
    	(Relocate_functions::rel32): Likewise.
    	(Relocate_functions::rel32_unaligned): Likewise.
    	(Relocate_functions::rela32): Likewise.
    	(Relocate_functions::pcrel32): Likewise.
    	(Relocate_functions::pcrel32_unaligned): Likewise.
    	(Relocate_functions::pcrela32): Likewise.
    	(Relocate_functions::rel8_check): New function.
    	(Relocate_functions::rela8_check): New function.
    	(Relocate_functions::pcrel8_check): New function.
    	(Relocate_functions::pcrela8_check): New function.
    	(Relocate_functions::rel16_check): New function.
    	(Relocate_functions::rela168_check): New function.
    	(Relocate_functions::pcrel16_check): New function.
    	(Relocate_functions::pcrela16_check): New function.
    	(Relocate_functions::rel32_check): New function.
    	(Relocate_functions::rel32_unaligned_check): New function.
    	(Relocate_functions::rela32_check): New function.
    	(Relocate_functions::pcrel32_check): New function.
    	(Relocate_functions::pcrel32_unaligned_check): New function.
    	(Relocate_functions::pcrela32_check): New function.
    	(Bits::has_unsigned_overflow32): New function.
    	(Bits::has_unsigned_overflow): New function.
    	* testsuite/Makefile.am (overflow_unittest): New test.
    	* testsuite/Makefile.in: Regenerate.
    	* testsuite/overflow_unittest.cc: New source file.
  4. Fix formatting of pe-mips.c file.

    Simon Marchi authored and nickclifton committed Feb 5, 2016
    	* pe-mips.c (coff_mips_reloc): Fix formatting.
  5. Change the default architecture value for ARC bfds so that they have …

    cupertinomiranda authored and nickclifton committed Feb 5, 2016
    …the lowest possible value, and hence can be merged with other ARC binaries wihtout changing their architecture value.
    
    bfd	* cpu-arc.c: Change default archure from bfd_mach_arc_arcv2
    	to bfd_mach_arc_arc600.
    
    binutils * testsuite/binutils-all/objdump.exp: Update expected default
    	architecture value for ARC binaries.
  6. Automatic date update in version.in

    GDB Administrator authored and brobecke committed Feb 5, 2016
Commits on Feb 4, 2016
  1. Prevent possible undefined behaviour computing the size of the scache…

    nickclifton committed Feb 4, 2016
    … by usingunsigned integers instead of signed integers.
    
    	* cgen-scache.c (scache_option_handler): Prevent possible
    	undefined behaviour computing the size of the scache by using
    	unsigned integers instead of signed integers.
  2. [testsuite] Remove BASEDIR

    Yao Qi
    Yao Qi committed Feb 4, 2016
    BASEDIR was added by https://sourceware.org/ml/gdb-patches/2013-10/msg00587.html
    in order to handle the different directory layout in serial testing
    and parallel testing.  BASEDIR is "gdb.base" in serial testing and is
    "outputs/gdb.base/TESTNAME" in parallel testing.  However, it doesn't
    work if the GDBserver is in remote target, like this,
    
    $ make check RUNTESTFLAGS='--target_board=remote-gdbserver-on-localhost foll-vfork.exp foll-exec.exp'
    FAIL: gdb.base/foll-exec.exp: continue to first exec catchpoint (the program exited)
    FAIL: gdb.base/foll-vfork.exp: exec: vfork and exec child follow, to main bp: continue to bp (the program exited)
    FAIL: gdb.base/foll-vfork.exp: exec: vfork child follow, finish after tcatch vfork: finish (the program exited)
    FAIL: gdb.base/foll-vfork.exp: exec: vfork relations in info inferiors: continue to bp (the program exited)
    
    these tests fail because the executable can't be found.  With target
    board native-gdbserver, the program is spawned this way,
    
     spawn ../gdbserver/gdbserver --once :2347 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/gdb.base/foll-vfork
    
    so BASEDIR is correct.  However, with target board
    remote-gdbserver-on-localhost, the program is spawned
    
      spawn /usr/bin/ssh -l yao localhost /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/../gdbserver/gdbserver --once :2346 /scratch/yao/gdb/build-git/x86_64/gdb/testsuite/gdb.base/foll-vfork
    
    so BASEDIR (either "gdb.base" or "outputs/gdb.base/TESTNAME") makes no
    sense.
    
    I had a fix that pass absolute directory to BASEDIR, but it assumes
    that directory structure is the same on build and target, and it
    doesn't work in remote host case.  The current fix in this patch is
    to get the directory from argv[0].  In any case, the program to be
    exec'ed is at the same directory with the main program.
    
    Note that these tests do "next N" to let program stop at the desired
    line, but it is fragile, because GDB for different targets may skip
    function prologue slightly differently, so I replace some of them by
    "tbreak on LINE NUMBER and continue".
    
    gdb/testsuite:
    
    2016-02-04  Yao Qi  <yao.qi@linaro.org>
    
    	* gdb.base/foll-exec-mode.c: Include limits.h.
    	(main): Add parameters argc and argv.  Get directory from
    	argv[0].
    	* gdb.base/foll-exec-mode.exp: Don't pass -DBASEDIR in
    	compilation.
    	* gdb.base/foll-exec.c: Include limits.h.
    	(main): Add parameters argc and argv.
    	Get directory from argv[0].
    	* gdb.base/foll-exec.exp: Don't pass -DBASEDIR in compilation.
    	Adjust tests on the number of lines as source code changed.
    	* gdb.base/foll-vfork-exit.c: Include limits.h.
    	(main): Add one line of statement before vfork.
    	* gdb.base/foll-vfork.c: Include limits.h and string.h.
    	(main): Add parameters argc and argv.  Get directory from
    	argv[0].
    	* gdb.base/foll-vfork.exp: Don't pass -DBASEDIR in compilation.
    	(setup_gdb): Set tbreak to skip some source lines.
    	* gdb.multi/bkpt-multi-exec.c: Include limits.h.
    	(main): Add parameters argc and argv.  Get directory from
    	argv[0].
    	* gdb.multi/bkpt-multi-exec.exp: Don't pass -DBASEDIR in
    	compilation.
    	* gdb.multi/multi-arch-exec.c: Include limits.h and string.h.
    	(main): Add parameters argc and argv.  Get directory from
    	argv[0].
    	* gdb.multi/multi-arch-exec.exp: Don't pass -DBASEDIR in
    	compilation.
  3. waiting_for_stop_reply around remote_fileio_request

    Yao Qi
    Yao Qi committed Feb 4, 2016
    Hi,
    I see this error when GDB connects with qemu,
    
    (gdb) n
    ....
    Sending packet: $vCont;c#a8...Ack
    Packet received: Ffstat,00000001,f6fff038
    Cannot execute this command while the target is running.
    Use the "interrupt" command to stop the target
    and then try again.
    
    looks we don't set rs->waiting_for_stop_reply to zero
    before handle fileio request,
    
     #10 0x00000000005edb64 in target_write (len=64, offset=4143968312, buf=0x7fffffffd570 "\375\377\377\377", annex=0x0, object=TARGET_OBJECT_MEMORY,
        ops=<optimised out>) at /home/yao/SourceCode/gnu/gdb/git/gdb/target.c:1922
     #11 target_write_memory (memaddr=memaddr@entry=4143968312, myaddr=myaddr@entry=0x7fffffffd6a0 "", len=len@entry=64)
        at /home/yao/SourceCode/gnu/gdb/git/gdb/target.c:1500
     #12 0x00000000004b2b41 in remote_fileio_func_fstat (buf=0x127b258 "") at /home/yao/SourceCode/gnu/gdb/git/gdb/remote-fileio.c:1037
     #13 0x00000000004b1878 in do_remote_fileio_request (uiout=<optimised out>, buf_arg=buf_arg@entry=0x127b240)
        at /home/yao/SourceCode/gnu/gdb/git/gdb/remote-fileio.c:1204
     #14 0x00000000005b8c7c in catch_exceptions_with_msg (func_uiout=<optimised out>, func=func@entry=0x4b1800 <do_remote_fileio_request>,
        func_args=func_args@entry=0x127b240, gdberrmsg=gdberrmsg@entry=0x0, mask=mask@entry=RETURN_MASK_ALL)
        at /home/yao/SourceCode/gnu/gdb/git/gdb/exceptions.c:187
     #15 0x00000000005b8dea in catch_exceptions (uiout=<optimised out>, func=func@entry=0x4b1800 <do_remote_fileio_request>, func_args=func_args@entry=0x127b240,
        mask=mask@entry=RETURN_MASK_ALL) at /home/yao/SourceCode/gnu/gdb/git/gdb/exceptions.c:167
     #16 0x00000000004b2fff in remote_fileio_request (buf=0x127b240 "Xf6fff038,0:", ctrlc_pending_p=0) at /home/yao/SourceCode/gnu/gdb/git/gdb/remote-fileio.c:1255
     #17 0x0000000000496f12 in remote_wait_as (ptid=..., status=0x7fffffffdb20, options=1) at /home/yao/SourceCode/gnu/gdb/git/gdb/remote.c:6997
    
    however, we did set rs->waiting_for_stop_reply to zero before Luis's
    patch https://sourceware.org/ml/gdb-patches/2015-10/msg00336.html
    
    In fact, Luis's patch v1
    https://sourceware.org/ml/gdb-patches/2015-08/msg00809.html is about
    setting rs->waiting_for_stop_reply back to one after
    remote_fileio_request, which is correct.  However during the review, the
    patch is changed and ends up with "not setting rs->waiting_for_stop_reply
    to zero".
    
    I manually test GDB, but I don't have a way to run regression tests.
    
    gdb:
    
    2016-02-04  Yao Qi  <yao.qi@linaro.org>
    
    	* remote.c (remote_wait_as): Set rs->waiting_for_stop_reply to
    	0 before handling 'F' and set it back afterwards.
  4. Remove support for creating ARM NOREAD sections.

    nickclifton committed Feb 4, 2016
    gas	* config/obj-elf.c (obj_elf_change_section): Remove support for
    	ARM NOREAD sections.
    	* config/tc-arm.c (arm_elf_section_letter): Delete.
    	* config/tc-arm.h (md_elf_section_letter): Delete.
    	* doc/c-arm.texi (ARM Section Attribute): Delete section.
    	* testsuite/gas/arm/section-execute-only.d: Delete.
    	* testsuite/gas/arm/section-execute-only.s: Delete.
    
    ld	* testsuite/ld-arm/arm-elf.exp: Remove ARM NOREAD section tests.
    	* testsuite/ld-arm/thumb1-input-section-flag-match.d: Delete.
    	* testsuite/ld-arm/thumb1-input-section-flag-match.s: Delete.
    	* testsuite/ld-arm/thumb1-noread-not-present-mixing-two-section.d: Delete.
    	* testsuite/ld-arm/thumb1-noread-not-present-mixing-two-section.s: Delete.
    	* testsuite/ld-arm/thumb1-noread-present-one-section.d: Delete.
    	* testsuite/ld-arm/thumb1-noread-present-one-section.s: Delete.
    	* testsuite/ld-arm/thumb1-noread-present-two-section.d: Delete.
    	* testsuite/ld-arm/thumb1-noread-present-two-section.s: Delete.
  5. Fix the encoding of the MSP430's RRUX instruction.

    nickclifton committed Feb 4, 2016
    	PR target/19561
    opcdoe	* msp430-dis.c (print_insn_msp430): Add a special case for
    	decoding an RRC instruction with the ZC bit set in the extension
    	word.
    
    include	* opcode/msp430.h (IGNORE_CARRY_BIT): New define.
    	(RRUX): Synthesise using case 2 rather than 7.
    
    gas	* config/tc-msp430.c (msp430_operands): Remove case 7.  Use case 2
    	to handle encoding of RRUX instruction.
    	* testsuite/gas/msp430/msp430x.s: Add more tests of the extended
    	shift instructions.
    	* testsuite/gas/msp430/msp430x.d: Update expected disassembly.
  6. Automatic date update in version.in

    GDB Administrator authored and brobecke committed Feb 4, 2016
Commits on Feb 3, 2016
  1. MAINTAINERS: Add Thiemo Seufer back, as a past maintainer

    Maciej W. Rozycki Maciej W. Rozycki
    Maciej W. Rozycki authored and Maciej W. Rozycki committed Feb 3, 2016
    Complement commit 26e0f8d ("* MAINTAINERS: Remove Thiemo Seufer.").
    
    	* MAINTAINERS (Past sim maintainers): Add Thiemo Seufer.
  2. xtensa: fix signedness of gas relocations

    jcmvbkbc committed Feb 2, 2016
    Change 1058c75 "Use signed data type for R_XTENSA_DIFF* relocation
    offsets." changed signedness of BFD_RELOC_XTENSA_DIFF* relocations
    substituted for BFD_RELOC_*. This made it impossible to encode arbitrary
    8-, 16- and 32-bit values, which broke e.g. debug info encoding by .loc
    directive. Revert this part and add test.
    
    gas/
    2016-02-03  Max Filippov  <jcmvbkbc@gmail.com>
    	* config/tc-xtensa.c (md_apply_fix): Mark BFD_RELOC_XTENSA_DIFF*
    	substitutions for BFD_RELOC_* as unsigned.
    	* gas/testsuite/gas/xtensa/all.exp: Add loc to list of xtensa
    	tests.
    	* gas/testsuite/gas/xtensa/loc.d: New file: loc test result
    	patterns.
    	* gas/testsuite/gas/xtensa/loc.s: New file: loc test.
  3. Add -mrelax-relocations= to x86 assembler

    hjl-tools committed Feb 3, 2016
    The x86 relax relocations introduced in binutils 2.26 aren't supported
    by linker on Solaris older than Solaris 12.  To use x86 assembler with
    older Solaris linker, this patch adds
    
    1. A command line option -mrelax-relocations= to x86 assembler to
    control whether to generate relax relocations.
    2. A configure option --enable-x86-relax-relocations to decide whether
    x86 assembler should generate relax relocations by default.  It is
    defaulted to yes, except for x86 Solaris targets older than Solaris 12.
    
    gas/
    
    	PR gas/19520
    	* NEWS: Mention new command line option -mrelax-relocations and
    	new configure option --enable-x86-relax-relocations for x86
    	target.
    	* config.in: Regenerated.
    	* configure.ac: Add --enable-x86-relax-relocations.
    	(ac_default_x86_relax_relocations): New.  Default to 1 except
    	for x86 Solaris targets older than Solaris 12.
    	(DEFAULT_GENERATE_X86_RELAX_RELOCATIONS): Define.
    	* configure: Likewise.
    	* config/tc-i386.c (generate_relax_relocations): New.
    	(OPTION_MRELAX_RELOCATIONS): Likewise.
    	(output_disp): Don't generate relax relocations if
    	generate_relax_relocations is 0.
    	(md_longopts): Add -mrelax-relocations.
    	(md_show_usage): Likewise.
    	(md_parse_option): Handle OPTION_MRELAX_RELOCATIONS.
    	* doc/c-i386.texi: Document -mrelax-relocations=.
    	* testsuite/gas/i386/got-no-relax.d: New file.
    	* testsuite/gas/i386/x86-64-gotpcrel-no-relax.d: Likewise.
    	* testsuite/gas/i386/got.d: Pass -mrelax-relocations=yes to as.
    	* testsuite/gas/i386/localpic.d: Likewise.
    	* testsuite/gas/i386/mixed-mode-reloc32.d: Likewise.
    	* testsuite/gas/i386/reloc32.d: Likewise.
    	* testsuite/gas/i386/x86-64-gotpcrel.d: Likewise.
    	* testsuite/gas/i386/x86-64-localpic.d: Likewise.
    	* testsuite/gas/i386/ilp32/x86-64-gotpcrel.d: Likewise.
    	* testsuite/gas/i386/ilp32/x86-64-localpic.d: Likewise.
    	* testsuite/gas/i386/i386.exp: Run got-no-relax and
    	x86-64-gotpcrel-no-relax.
    
    ld/
    
    	PR gas/19520
    	* testsuite/ld-i386/branch1.d: Pass -mrelax-relocations=yes to as.
    	* testsuite/ld-i386/call1.d: Likewise.
    	* testsuite/ld-i386/call2.d: Likewise.
    	* testsuite/ld-i386/call3a.d: Likewise.
    	* testsuite/ld-i386/call3b.d: Likewise.
    	* testsuite/ld-i386/call3c.d: Likewise.
    	* testsuite/ld-i386/call3d.d: Likewise.
    	* testsuite/ld-i386/call3e.d: Likewise.
    	* testsuite/ld-i386/call3f.d: Likewise.
    	* testsuite/ld-i386/call3g.d: Likewise.
    	* testsuite/ld-i386/call3h.d: Likewise.
    	* testsuite/ld-i386/jmp1.d: Likewise.
    	* testsuite/ld-i386/jmp2.d: Likewise.
    	* testsuite/ld-i386/lea1c.d: Likewise.
    	* testsuite/ld-i386/load1.d: Likewise.
    	* testsuite/ld-i386/load2.d: Likewise.
    	* testsuite/ld-i386/load3.d: Likewise.
    	* testsuite/ld-i386/load4a.d: Likewise.
    	* testsuite/ld-i386/load5a.d: Likewise.
    	* testsuite/ld-i386/mov2b.d: Likewise.
    	* testsuite/ld-i386/mov3.d: Likewise.
    	* testsuite/ld-ifunc/ifunc-21-x86-64.d: Likewise.
    	* testsuite/ld-ifunc/ifunc-22-x86-64.d: Likewise.
    	* testsuite/ld-ifunc/ifunc-5r-local-x86-64.d: Likewise.
    	* testsuite/ld-x86-64/call1a.d: Likewise.
    	* testsuite/ld-x86-64/call1b.d: Likewise.
    	* testsuite/ld-x86-64/call1c.d: Likewise.
    	* testsuite/ld-x86-64/call1d.d: Likewise.
    	* testsuite/ld-x86-64/call1e.d: Likewise.
    	* testsuite/ld-x86-64/call1f.d: Likewise.
    	* testsuite/ld-x86-64/call1h.d: Likewise.
    	* testsuite/ld-x86-64/call1i.d: Likewise.
    	* testsuite/ld-x86-64/load1a.d: Likewise.
    	* testsuite/ld-x86-64/load1b.d: Likewise.
    	* testsuite/ld-i386/got1a.S: Load GOT into %ecx and use it.
    	* testsuite/ld-i386/got1.dd: Updated.
    	* testsuite/ld-i386/got1d.S (1): Removed.
    	* testsuite/ld-i386/i386.exp: Add -Wa,-mrelax-relocations=yes.
    	* testsuite/ld-x86-64/x86-64.exp: Likewise.
Older
You can’t perform that action at this time.